Issue 2517653003: Drag-and-drop across OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2517653003: Drag-and-drop across OOPIFs. (Closed)

Created:
4 years, 1 month ago by paulmeyer

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Drag-and-drop across OOPIFs. This patch enables drag-and-drop to work across out-of-process iframes. BUG=647249, 655063 Review-Url: https://codereview.chromium.org/2508013002 Cr-Commit-Position: refs/heads/master@{#433068} (cherry picked from commit 90572ae460ace736685280a608590812abf6bc6a) Committed: https://chromium.googlesource.com/chromium/src/+/4ee134950d793e5cd43ecdb871639f2cb2cd67c9

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -88 lines)			Patch
M	third_party/WebKit/Source/core/page/DragController.h	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	third_party/WebKit/Source/core/page/DragController.cpp	View	15 chunks	+38 lines, -39 lines	0 comments	Download
M	third_party/WebKit/Source/web/ChromeClientImpl.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebFrameWidgetBase.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebFrameWidgetBase.cpp	View	6 chunks	+44 lines, -8 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebViewImpl.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebViewImpl.cpp	View	6 chunks	+6 lines, -25 lines	0 comments	Download
M	third_party/WebKit/Source/web/tests/WebViewTest.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

paulmeyer

4 years, 1 month ago (2016-11-18 22:27:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4ee134950d793e5cd43ecdb871639f2cb2cd67c9.