Drag-and-drop across OOPIFs.

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 58 matching lines @@
 #include "core/layout/LayoutPart.h"
 #include "core/layout/TextAutosizer.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/layout/compositing/PaintLayerCompositor.h"
 #include "core/loader/FrameLoadRequest.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "core/loader/FrameLoaderStateMachine.h"
 #include "core/page/ContextMenuController.h"
 #include "core/page/ContextMenuProvider.h"
-#include "core/page/DragController.h"
-#include "core/page/DragData.h"
-#include "core/page/DragSession.h"
 #include "core/page/FocusController.h"
 #include "core/page/FrameTree.h"
 #include "core/page/Page.h"
 #include "core/page/PagePopupClient.h"
 #include "core/page/PointerLockController.h"
 #include "core/page/ScopedPageLoadDeferrer.h"
 #include "core/page/TouchDisambiguation.h"
 #include "core/page/scrolling/TopDocumentRootScrollerController.h"
 #include "core/paint/PaintLayer.h"
 #include "core/timing/DOMWindowPerformance.h"
@@ skipping 24 matching lines @@
 #include "platform/graphics/ImageBuffer.h"
 #include "platform/graphics/gpu/DrawingBuffer.h"
 #include "platform/graphics/paint/DrawingRecorder.h"
 #include "platform/image-decoders/ImageDecoder.h"
 #include "platform/scroll/ScrollbarTheme.h"
 #include "platform/tracing/TraceEvent.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebCompositeAndReadbackAsyncCallback.h"
 #include "public/platform/WebCompositorSupport.h"
-#include "public/platform/WebDragData.h"
 #include "public/platform/WebFloatPoint.h"
 #include "public/platform/WebGestureCurve.h"
 #include "public/platform/WebImage.h"
 #include "public/platform/WebLayerTreeView.h"
 #include "public/platform/WebScheduler.h"
 #include "public/platform/WebTextInputInfo.h"
 #include "public/platform/WebURLRequest.h"
 #include "public/platform/WebVector.h"
 #include "public/platform/WebViewScheduler.h"
 #include "public/web/WebAXObject.h"
@@ skipping 95 matching lines @@
 // Used to defer all page activity in cases where the embedder wishes to run
 // a nested event loop. Using a stack enables nesting of message loop
 // invocations.
 static Vector<std::unique_ptr<ScopedPageLoadDeferrer>>&
 pageLoadDeferrerStack() {
   DEFINE_STATIC_LOCAL(Vector<std::unique_ptr<ScopedPageLoadDeferrer>>,
                       deferrerStack, ());
   return deferrerStack;
 }
 
-// Ensure that the WebDragOperation enum values stay in sync with the original
-// DragOperation constants.
-// TODO(paulmeyer): Move this into WebFrameWidgetBase once all drag-and-drop
-// functions are out of WebViewImpl. See crbug.com/647249.
-#define STATIC_ASSERT_ENUM(a, b)                            \
-  static_assert(static_cast<int>(a) == static_cast<int>(b), \
-                "mismatching enum : " #a)
-STATIC_ASSERT_ENUM(DragOperationNone, WebDragOperationNone);
-STATIC_ASSERT_ENUM(DragOperationCopy, WebDragOperationCopy);
-STATIC_ASSERT_ENUM(DragOperationLink, WebDragOperationLink);
-STATIC_ASSERT_ENUM(DragOperationGeneric, WebDragOperationGeneric);
-STATIC_ASSERT_ENUM(DragOperationPrivate, WebDragOperationPrivate);
-STATIC_ASSERT_ENUM(DragOperationMove, WebDragOperationMove);
-STATIC_ASSERT_ENUM(DragOperationDelete, WebDragOperationDelete);
-STATIC_ASSERT_ENUM(DragOperationEvery, WebDragOperationEvery);
-
 static bool shouldUseExternalPopupMenus = false;
 
 namespace {
 
 class EmptyEventListener final : public EventListener {
  public:
   static EmptyEventListener* create() { return new EmptyEventListener(); }
 
   bool operator==(const EventListener& other) const override {
     return this == &other;
@@ skipping 104 matching lines @@
       m_zoomLevel(0),
       m_minimumZoomLevel(zoomFactorToZoomLevel(minTextSizeMultiplier)),
       m_maximumZoomLevel(zoomFactorToZoomLevel(maxTextSizeMultiplier)),
       m_zoomFactorForDeviceScaleFactor(0.f),
       m_maximumLegibleScale(1),
       m_doubleTapZoomPageScaleFactor(0),
       m_doubleTapZoomPending(false),
       m_enableFakePageScaleAnimationForTesting(false),
       m_fakePageScaleAnimationPageScaleFactor(0),
       m_fakePageScaleAnimationUseAnchor(false),
-      m_doingDragAndDrop(false),
       m_ignoreInputEvents(false),
       m_compositorDeviceScaleFactorOverride(0),
       m_suppressNextKeypressEvent(false),
       m_imeAcceptEvents(true),
       m_devToolsEmulator(nullptr),
       m_isTransparent(false),
       m_tabsToLinks(false),
       m_layerTreeView(nullptr),
       m_rootLayer(nullptr),
       m_rootGraphicsLayer(nullptr),
@@ skipping 56 matching lines @@
 WebViewImpl::~WebViewImpl() {
   DCHECK(!m_page);
 
   // Each highlight uses m_owningWebViewImpl->m_linkHighlightsTimeline
   // in destructor. m_linkHighlightsTimeline might be destroyed earlier
   // than m_linkHighlights.
   DCHECK(m_linkHighlights.isEmpty());
 }
 
 WebViewImpl::UserGestureNotifier::UserGestureNotifier(WebViewImpl* view)
+    // TODO(kenrb, alexmos): |m_frame| should be set to the local root frame,
+    // not the main frame. See crbug.com/589894.
     : m_frame(view->mainFrameImpl()),
       m_userGestureObserved(&view->m_userGestureObserved) {
   DCHECK(m_userGestureObserved);
 }
 
 WebViewImpl::UserGestureNotifier::~UserGestureNotifier() {
-  if (!*m_userGestureObserved &&
+  if (!*m_userGestureObserved && m_frame &&
       m_frame->frame()->document()->hasReceivedUserGesture()) {
     *m_userGestureObserved = true;
     if (m_frame && m_frame->autofillClient())
       m_frame->autofillClient()->firstUserGestureObserved();
   }
 }
 
 WebDevToolsAgentImpl* WebViewImpl::mainFrameDevToolsAgentImpl() {
   WebLocalFrameImpl* mainFrame = mainFrameImpl();
   return mainFrame ? mainFrame->devToolsAgentImpl() : nullptr;
@@ skipping 1659 matching lines @@
   // submitted. To avoid that, GestureTap is handled explicitly:
   if (inputEvent.type == WebInputEvent::GestureTap && autofillClient) {
     m_userGestureObserved = true;
     autofillClient->firstUserGestureObserved();
   }
 
   page()->frameHost().visualViewport().startTrackingPinchStats();
 
   TRACE_EVENT1("input,rail", "WebViewImpl::handleInputEvent", "type",
                WebInputEvent::GetName(inputEvent.type));
-  // If we've started a drag and drop operation, ignore input events until
-  // we're done.
-  if (m_doingDragAndDrop)
+
+  // If a drag-and-drop operation is in progress, ignore input events.
+  if (mainFrameImpl()->frameWidget()->doingDragAndDrop())
     return WebInputEventResult::HandledSuppressed;
 
   if (m_devToolsEmulator->handleInputEvent(inputEvent))
     return WebInputEventResult::HandledSuppressed;
 
   if (InspectorOverlay* overlay = inspectorOverlay()) {
     if (overlay->handleInputEvent(inputEvent))
       return WebInputEventResult::HandledSuppressed;
   }
 
@@ skipping 2059 matching lines @@
   if (focusedFrame->localFrameRoot() != mainFrameImpl()->frame())
     return nullptr;
   return focusedFrame;
 }
 
 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const {
   return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
 }
 
 }  // namespace blink