Issue 2517513004: Move QUIC error code utility methods to quic_error_codes.{h,cc}, and rename them slightly. No beha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2517513004: Move QUIC error code utility methods to quic_error_codes.{h,cc}, and rename them slightly. No beha… (Closed)

Created:
4 years, 1 month ago by mpw

Modified:
4 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move QUIC error code utility methods to quic_error_codes.{h,cc}, and rename them slightly. No behavior change. Merge internal change: 138891075 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+212 lines, -171 lines)			Patch
M	net/log/net_log_util.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	net/net.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_connection.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	net/quic/core/quic_crypto_stream.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/core/quic_error_codes.h	View	3 chunks	+15 lines, -2 lines	0 comments	Download
A	net/quic/core/quic_error_codes.cc	View	1 chunk	+144 lines, -0 lines	0 comments	Download
A	net/quic/core/quic_error_codes_test.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_framer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/core/quic_framer_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/core/quic_stream_sequencer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/core/quic_utils.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/quic/core/quic_utils.cc	View	1 chunk	+0 lines, -133 lines	0 comments	Download
M	net/quic/core/quic_utils_test.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	net/tools/quic/quic_client_bin.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_packet_printer_bin.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_simple_client_bin.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2515873002 Patch 1

Dependent Patchsets:

Issue 2512273002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages