Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: net/quic/core/quic_connection.cc

Issue 2517513004: Move QUIC error code utility methods to quic_error_codes.{h,cc}, and rename them slightly. No beha… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/net.gypi ('k') | net/quic/core/quic_crypto_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection.cc
diff --git a/net/quic/core/quic_connection.cc b/net/quic/core/quic_connection.cc
index da418fa0d9a6b6c496f234cfadd401a5a5819356..806fab3996e46e59e2858a6bfc446169c1bfaeaf 100644
--- a/net/quic/core/quic_connection.cc
+++ b/net/quic/core/quic_connection.cc
@@ -866,7 +866,7 @@ bool QuicConnection::OnRstStreamFrame(const QuicRstStreamFrame& frame) {
DVLOG(1) << ENDPOINT
<< "RST_STREAM_FRAME received for stream: " << frame.stream_id
<< " with error: "
- << QuicUtils::StreamErrorToString(frame.error_code);
+ << QuicRstStreamErrorCodeToString(frame.error_code);
visitor_->OnRstStream(frame);
visitor_->PostProcessAfterData();
should_last_packet_instigate_acks_ = true;
@@ -881,7 +881,7 @@ bool QuicConnection::OnConnectionCloseFrame(
}
DVLOG(1) << ENDPOINT
<< "Received ConnectionClose for connection: " << connection_id()
- << ", with error: " << QuicUtils::ErrorToString(frame.error_code)
+ << ", with error: " << QuicErrorCodeToString(frame.error_code)
<< " (" << frame.error_details << ")";
if (frame.error_code == QUIC_BAD_MULTIPATH_FLAG) {
LOG(ERROR) << "Unexpected QUIC_BAD_MULTIPATH_FLAG error."
@@ -900,7 +900,7 @@ bool QuicConnection::OnGoAwayFrame(const QuicGoAwayFrame& frame) {
}
DVLOG(1) << ENDPOINT << "GOAWAY_FRAME received with last good stream: "
<< frame.last_good_stream_id
- << " and error: " << QuicUtils::ErrorToString(frame.error_code)
+ << " and error: " << QuicErrorCodeToString(frame.error_code)
<< " and reason: " << frame.reason_phrase;
goaway_received_ = true;
@@ -1962,8 +1962,8 @@ void QuicConnection::CloseConnection(
}
DVLOG(1) << ENDPOINT << "Closing connection: " << connection_id()
- << ", with error: " << QuicUtils::ErrorToString(error) << " ("
- << error << "), and details: " << error_details;
+ << ", with error: " << QuicErrorCodeToString(error) << " (" << error
+ << "), and details: " << error_details;
if (connection_close_behavior ==
ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET) {
@@ -2041,7 +2041,7 @@ void QuicConnection::SendGoAway(QuicErrorCode error,
goaway_sent_ = true;
DVLOG(1) << ENDPOINT << "Going away with error "
- << QuicUtils::ErrorToString(error) << " (" << error << ")";
+ << QuicErrorCodeToString(error) << " (" << error << ")";
// Opportunistically bundle an ack with this outgoing packet.
ScopedPacketBundler ack_bundler(this, SEND_ACK_IF_PENDING);
« no previous file with comments | « net/net.gypi ('k') | net/quic/core/quic_crypto_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698