Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2517463005: Timeline: nuke flow events experiment (Closed)

Created:
4 years, 1 month ago by caseq
Modified:
4 years, 1 month ago
Reviewers:
alph, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: nuke flow events experiment This removes timelineFlowEvents experiment that used to enable top-level flow events and visualize these with arrows on flame chart. Committed: https://crrev.com/f23c9c9ec07dcbdf68ee5033cc731274e38d0d50 Cr-Commit-Position: refs/heads/master@{#433359}

Patch Set 1 #

Total comments: 1

Patch Set 2 : also removed flow events support from FlameChart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -106 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 5 chunks +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 3 chunks +0 lines, -55 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
caseq
ptal
4 years, 1 month ago (2016-11-18 19:57:19 UTC) #3
dgozman
https://codereview.chromium.org/2517463005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js (left): https://codereview.chromium.org/2517463005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js#oldcode621 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:621: timelineData.flowStartTimes.push(event.startTime); Do you want to remove support from FlameChart ...
4 years, 1 month ago (2016-11-18 20:07:08 UTC) #4
caseq
On 2016/11/18 20:07:08, dgozman wrote: > https://codereview.chromium.org/2517463005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js > File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js > (left): > > https://codereview.chromium.org/2517463005/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js#oldcode621 ...
4 years, 1 month ago (2016-11-18 22:10:08 UTC) #6
dgozman
lgtm
4 years, 1 month ago (2016-11-18 23:22:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517463005/40001
4 years, 1 month ago (2016-11-18 23:23:55 UTC) #9
alph
lgtm
4 years, 1 month ago (2016-11-18 23:48:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-19 00:57:28 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:00:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f23c9c9ec07dcbdf68ee5033cc731274e38d0d50
Cr-Commit-Position: refs/heads/master@{#433359}

Powered by Google App Engine
This is Rietveld 408576698