Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2517463005: Timeline: nuke flow events experiment (Closed)
Patch Set: also removed flow events support from FlameChart Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
index ecd696867a50fea3608a9893a51a43902194e229..062f189d555337145829337dd7ed2c3848f86156 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -159,7 +159,6 @@ Timeline.TimelineFlameChartDataProvider = class extends Timeline.TimelineFlameCh
this._timelineData = new UI.FlameChart.TimelineData([], [], [], []);
- this._flowEventIndexById = {};
this._minimumBoundary = this._model.minimumRecordTime();
this._timeSpan = this._model.isEmpty() ? 1000 : this._model.maximumRecordTime() - this._minimumBoundary;
this._currentLevel = 0;
@@ -217,7 +216,6 @@ Timeline.TimelineFlameChartDataProvider = class extends Timeline.TimelineFlameCh
this._markers.sort(compareStartTime);
this._timelineData.markers = this._markers;
- this._flowEventIndexById = {};
return this._timelineData;
}
@@ -254,7 +252,6 @@ Timeline.TimelineFlameChartDataProvider = class extends Timeline.TimelineFlameCh
*/
_appendSyncEvents(events, title, style, forceExpanded) {
var openEvents = [];
- var flowEventsEnabled = Runtime.experiments.isEnabled('timelineFlowEvents');
var blackboxingEnabled = Runtime.experiments.isEnabled('blackboxJSFramesOnTimeline');
var maxStackDepth = 0;
for (var i = 0; i < events.length; ++i) {
@@ -288,8 +285,6 @@ Timeline.TimelineFlameChartDataProvider = class extends Timeline.TimelineFlameCh
var level = this._currentLevel + openEvents.length;
this._appendEvent(e, level);
- if (flowEventsEnabled)
- this._appendFlowEvent(e, level);
maxStackDepth = Math.max(maxStackDepth, openEvents.length + 1);
if (e.endTime)
openEvents.push(e);
@@ -607,47 +602,6 @@ Timeline.TimelineFlameChartDataProvider = class extends Timeline.TimelineFlameCh
}
/**
- * @param {!SDK.TracingModel.Event} event
- * @param {number} level
- */
- _appendFlowEvent(event, level) {
- var timelineData = this._timelineData;
- /**
- * @param {!SDK.TracingModel.Event} event
- * @return {number}
- */
- function pushStartFlow(event) {
- var flowIndex = timelineData.flowStartTimes.length;
- timelineData.flowStartTimes.push(event.startTime);
- timelineData.flowStartLevels.push(level);
- return flowIndex;
- }
-
- /**
- * @param {!SDK.TracingModel.Event} event
- * @param {number} flowIndex
- */
- function pushEndFlow(event, flowIndex) {
- timelineData.flowEndTimes[flowIndex] = event.startTime;
- timelineData.flowEndLevels[flowIndex] = level;
- }
-
- switch (event.phase) {
- case SDK.TracingModel.Phase.FlowBegin:
- this._flowEventIndexById[event.id] = pushStartFlow(event);
- break;
- case SDK.TracingModel.Phase.FlowStep:
- pushEndFlow(event, this._flowEventIndexById[event.id]);
- this._flowEventIndexById[event.id] = pushStartFlow(event);
- break;
- case SDK.TracingModel.Phase.FlowEnd:
- pushEndFlow(event, this._flowEventIndexById[event.id]);
- delete this._flowEventIndexById[event.id];
- break;
- }
- }
-
- /**
* @param {!SDK.TracingModel.AsyncEvent} asyncEvent
* @param {number} level
*/

Powered by Google App Engine
This is Rietveld 408576698