third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 2517383002: Use the font height as caret height instead of the line height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2517383002: Use the font height as caret height instead of the line height (Closed)

Patch Set: fix test fail Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index 02aa28ad9febd56dfd8818de2bec1b76af3997b5..3d401e1b5a527055bdca5e16532f6fb6ec64fe1f 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -2552,7 +2552,7 @@ LayoutRect localCaretRectOfPositionTemplate(

boxPosition.offsetInBox);

}

-// This function was added because the caret rect that will be calcaulated by

+// This function was added because the caret rect that is calculated by

// using the line top value instead of the selection top.

template <typename Strategy>

LayoutRect localSelectionRectOfPositionTemplate(