Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: third_party/WebKit/LayoutTests/editing/caret/caret-height-multi-line.html

Issue 2517383002: Use the font height as caret height instead of the line height (Closed)
Patch Set: fix test fail Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/editing/caret/caret-height-multi-line.html
diff --git a/third_party/WebKit/LayoutTests/editing/caret/caret-height-multi-line.html b/third_party/WebKit/LayoutTests/editing/caret/caret-height-multi-line.html
new file mode 100644
index 0000000000000000000000000000000000000000..2d7ced67bfe826ff28f91289c2ce3f6dc81ae817
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/editing/caret/caret-height-multi-line.html
@@ -0,0 +1,96 @@
+<!DOCTYPE html>
+<html>
+<head>
+<style>
+div {
+ border: 2px solid red;
+ padding: 12px;
+ line-height: 1.66666667;
+ width: 140px;
+}
+</style>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+</head>
+<body>
+ <div contenteditable id="test1">
+ The caret height
+ should <span id="line2">be the same for each line.</span>
+ </div>
+ <div contenteditable id="test2">
+ The <span id="large_font" style="font-size: 150%">caret</span> height should be obtained from a font of character before caret for LTR.
+ </div>
+ <div contenteditable id="test3" style="direction: RTL">גובה<span id="large_font_rtl" style="font-size: 150%">עבו</span> תו יש לקבל תו אחרי תו עבור RTL
+ </div>
+<script>
+test(function () {
+ let editor = document.getElementById('test1');
+ editor.focus();
+
+ assert_not_equals(window.internals, undefined, 'This test requires window.internals');
+ let caretHeight1 = window.internals.absoluteCaretBounds().height;
+ let sel = window.getSelection();
+ sel.collapse(line2, 0);
+ let caretHeight2 = window.internals.absoluteCaretBounds().height;
+
+ assert_equals(caretHeight1, caretHeight2);
+}, 'The caret height should be the same in every line');
+
+test(function () {
+ let editor = document.getElementById('test2');
+ editor.focus();
+
+ assert_not_equals(window.internals, undefined, 'This test requires window.internals');
+ let caretHeight1 = window.internals.absoluteCaretBounds().height;
+ let sel = window.getSelection();
+ sel.collapse(large_font, 0);
+ let caretHeight2 = window.internals.absoluteCaretBounds().height;
+
+ assert_equals(caretHeight1, caretHeight2);
+}, 'The caret height at the front of word(150%) should be the same as the caret height in other words(100%).');
+
+test(function () {
+ let editor = document.getElementById('test2');
+ editor.focus();
+
+ assert_not_equals(window.internals, undefined, 'This test requires window.internals');
+ let sel = window.getSelection();
+ sel.collapse(large_font, 0);
+ sel.modify('move', 'right', 'character');
+ let caretHeight1 = window.internals.absoluteCaretBounds().height;
+ sel.collapse(large_font, 1);
+ let caretHeight2 = window.internals.absoluteCaretBounds().height;
+
+ assert_equals(caretHeight1, caretHeight2);
+}, 'The caret height at the end of word should be the same as the caret height in the word.');
+
+test(function () {
+ let editor = document.getElementById('test3');
+ editor.focus();
+
+ assert_not_equals(window.internals, undefined, 'This test requires window.internals');
+ let caretHeight1 = window.internals.absoluteCaretBounds().height;
+ let sel = window.getSelection();
+ sel.collapse(large_font_rtl, 0);
+ let caretHeight2 = window.internals.absoluteCaretBounds().height;
+
+ assert_equals(caretHeight1, caretHeight2);
+}, 'In case of RTL, the caret height at the front of word(150%) should be the same as the caret height in other words(100%).');
+
+test(function () {
+ let editor = document.getElementById('test3');
+ editor.focus();
+
+ assert_not_equals(window.internals, undefined, 'This test requires window.internals');
+ let sel = window.getSelection();
+ sel.collapse(large_font_rtl, 0);
+ sel.modify('move', 'left', 'character');
+ let caretHeight1 = window.internals.absoluteCaretBounds().height;
+ sel.collapse(large_font_rtl, 1);
+ let caretHeight2 = window.internals.absoluteCaretBounds().height;
+
+ assert_equals(caretHeight1, caretHeight2);
+}, 'In case of RTL, the caret height at the end of word should be the same as the caret height in the word.');
+</script>
+</body>
+</html>
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698