Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2517383002: Use the font height as caret height instead of the line height (Closed)
Patch Set: update comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.h b/third_party/WebKit/Source/core/editing/VisibleUnits.h
index 2e33c5d5407bef25b1cb3cbc3d66c8b8a113f83f..02c88b3433d9fbb8c00185ad3b933e931a6704a4 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.h
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.h
@@ -120,6 +120,9 @@ CORE_EXPORT PositionInFlatTree canonicalPositionOf(const PositionInFlatTree&);
CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&);
CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePositionInFlatTree&);
+CORE_EXPORT IntRect absoluteSelectionBoundsOf(const VisiblePosition&);
yosin_UTC9 2017/01/05 07:31:31 Can we move introducing absoluteSelectionBoundsOf(
joone 2017/01/06 20:40:43 Done: https://codereview.chromium.org/2616103003/
+CORE_EXPORT IntRect absoluteSelectionBoundsOf(const VisiblePositionInFlatTree&);
+
CORE_EXPORT UChar32 characterAfter(const VisiblePosition&);
CORE_EXPORT UChar32 characterAfter(const VisiblePositionInFlatTree&);
CORE_EXPORT UChar32 characterBefore(const VisiblePosition&);
@@ -307,6 +310,9 @@ computeInlineBoxPosition(const VisiblePositionInFlatTree&);
// Rect is local to the returned layoutObject
CORE_EXPORT LayoutRect localCaretRectOfPosition(const PositionWithAffinity&,
LayoutObject*&);
+CORE_EXPORT LayoutRect localSelectionRectOfPosition(const PositionWithAffinity&,
yosin_UTC9 2017/01/05 07:31:31 It seems we don't need to export this function.
joone 2017/01/06 20:40:43 Removed.
+ LayoutObject*&);
+
CORE_EXPORT LayoutRect
localCaretRectOfPosition(const PositionInFlatTreeWithAffinity&, LayoutObject*&);
bool hasRenderedNonAnonymousDescendantsWithHeight(LayoutObject*);

Powered by Google App Engine
This is Rietveld 408576698