Use the font height as caret height instead of the line height

third_party/WebKit/Source/core/editing/VisibleUnits.h

 /*
  * Copyright (C) 2004 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 102 matching lines @@
 // If true, adjacent candidates are visually distinct.
 CORE_EXPORT bool endsOfNodeAreVisuallyDistinctPositions(const Node*);
 
 CORE_EXPORT Position canonicalPositionOf(const Position&);
 CORE_EXPORT PositionInFlatTree canonicalPositionOf(const PositionInFlatTree&);
 
 // Bounds of (possibly transformed) caret in absolute coords
 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&);
 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePositionInFlatTree&);
 
+CORE_EXPORT IntRect absoluteSelectionBoundsOf(const VisiblePosition&);

[yosin_UTC9, 2017/01/05 07:31:31]

Can we move introducing absoluteSelectionBoundsOf() and updating
GranularityStrategy.cpp and GranularityStrategyTest.cpp in another patch?

[joone, 2017/01/06 20:40:43]

Done: https://codereview.chromium.org/2616103003/

+CORE_EXPORT IntRect absoluteSelectionBoundsOf(const VisiblePositionInFlatTree&);
+
 CORE_EXPORT UChar32 characterAfter(const VisiblePosition&);
 CORE_EXPORT UChar32 characterAfter(const VisiblePositionInFlatTree&);
 CORE_EXPORT UChar32 characterBefore(const VisiblePosition&);
 CORE_EXPORT UChar32 characterBefore(const VisiblePositionInFlatTree&);
 
 // TODO(yosin) Since return value of |leftPositionOf()| with |VisiblePosition|
 // isn't defined well on flat tree, we should not use it for a position in
 // flat tree.
 CORE_EXPORT VisiblePosition leftPositionOf(const VisiblePosition&);
 CORE_EXPORT VisiblePositionInFlatTree
@@ skipping 167 matching lines @@
 computeInlineBoxPosition(const PositionInFlatTree&,
                          TextAffinity,
                          TextDirection primaryDirection);
 CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const VisiblePosition&);
 CORE_EXPORT InlineBoxPosition
 computeInlineBoxPosition(const VisiblePositionInFlatTree&);
 
 // Rect is local to the returned layoutObject
 CORE_EXPORT LayoutRect localCaretRectOfPosition(const PositionWithAffinity&,
                                                 LayoutObject*&);
+CORE_EXPORT LayoutRect localSelectionRectOfPosition(const PositionWithAffinity&,

[yosin_UTC9, 2017/01/05 07:31:31]

It seems we don't need to export this function.

[joone, 2017/01/06 20:40:43]

Removed.

+                                                    LayoutObject*&);
+
 CORE_EXPORT LayoutRect
 localCaretRectOfPosition(const PositionInFlatTreeWithAffinity&, LayoutObject*&);
 bool hasRenderedNonAnonymousDescendantsWithHeight(LayoutObject*);
 
 // Returns a hit-tested VisiblePosition for the given point in contents-space
 // coordinates.
 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&,
                                                             LocalFrame*);
 
 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&);
 
 }  // namespace blink
 
 #endif  // VisibleUnits_h