Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2517343003: Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher (Closed)

Created:
4 years, 1 month ago by xlai (Olivia)
Modified:
4 years ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. TBR=junov@chromium.org BUG=662498 Committed: https://crrev.com/454256046619fba9e01a6a1f32ed4dd649ae6553 Cr-Commit-Position: refs/heads/master@{#434308}

Patch Set 1 #

Total comments: 1

Patch Set 2 : get rid of clamepTo Int #

Patch Set 3 : rebase and fix compilation #

Patch Set 4 : fix error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 2 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 37 (21 generated)
xlai (Olivia)
A partial CL from https://codereview.chromium.org/2521013003/. Because changing compositing layer requires major refactoring on SurfaceLayer side, ...
4 years, 1 month ago (2016-11-22 17:39:29 UTC) #2
xidachen
https://codereview.chromium.org/2517343003/diff/1/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp (right): https://codereview.chromium.org/2517343003/diff/1/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp#newcode57 third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:57: m_frameDispatcher->reshape(width(), height()); As discussed offline, please change this to ...
4 years, 1 month ago (2016-11-22 18:41:45 UTC) #3
xlai (Olivia)
Patch changed. Now we get rid of clampTo<Int> in OffscreenCanvasframedispatcher
4 years ago (2016-11-23 15:40:22 UTC) #6
xidachen
lgtm
4 years ago (2016-11-23 15:41:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343003/20001
4 years ago (2016-11-23 15:56:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343003/20001
4 years ago (2016-11-23 16:02:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg/builds/37967) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-11-23 16:06:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343003/40001
4 years ago (2016-11-23 17:32:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343003/60001
4 years ago (2016-11-23 19:32:32 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/341726)
4 years ago (2016-11-23 20:52:11 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343003/60001
4 years ago (2016-11-23 21:51:47 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 02:44:25 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343003/60001
4 years ago (2016-11-24 03:43:30 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-24 06:01:38 UTC) #34
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/454256046619fba9e01a6a1f32ed4dd649ae6553 Cr-Commit-Position: refs/heads/master@{#434308}
4 years ago (2016-11-24 06:04:08 UTC) #36
Justin Novosad
4 years ago (2016-11-28 16:10:26 UTC) #37
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698