|
|
Created:
4 years, 1 month ago by xlai (Olivia) Modified:
4 years ago CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher
In addition to that, this CL makes OffscreenCanvasFrameDispatcher own
FrameSinkId only, because the localFrameId will be changed in resizing
workflow.
TBR=junov@chromium.org
BUG=662498
Committed: https://crrev.com/454256046619fba9e01a6a1f32ed4dd649ae6553
Cr-Commit-Position: refs/heads/master@{#434308}
Patch Set 1 #
Total comments: 1
Patch Set 2 : get rid of clamepTo Int #Patch Set 3 : rebase and fix compilation #Patch Set 4 : fix error #
Messages
Total messages: 37 (21 generated)
xlai@chromium.org changed reviewers: + xidachen@chromium.org
A partial CL from https://codereview.chromium.org/2521013003/. Because changing compositing layer requires major refactoring on SurfaceLayer side, I'll prefer to land this first.
https://codereview.chromium.org/2517343003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp (right): https://codereview.chromium.org/2517343003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:57: m_frameDispatcher->reshape(width(), height()); As discussed offline, please change this to use m_size.width() and m_size.height(), so that we are passing int, and we can avoid conversion from int-->unsigned-->int round trip.
Description was changed from ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher BUG=662498 ========== to ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only. BUG=662498 ==========
Description was changed from ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only. BUG=662498 ========== to ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. BUG=662498 ==========
Patch changed. Now we get rid of clampTo<Int> in OffscreenCanvasframedispatcher
lgtm
The CQ bit was checked by xlai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xlai@chromium.org
Description was changed from ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. BUG=662498 ========== to ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. TBR=junov@chromium.org BUG=662498 ==========
xlai@chromium.org changed reviewers: + junov@chromium.org
The CQ bit was checked by xlai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by xlai@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xidachen@chromium.org Link to the patchset: https://codereview.chromium.org/2517343003/#ps40001 (title: "rebase and fix compilation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xlai@chromium.org
The CQ bit was checked by xlai@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xidachen@chromium.org Link to the patchset: https://codereview.chromium.org/2517343003/#ps60001 (title: "fix error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by xlai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by xlai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479958969092670, "parent_rev": "b1c65d59f1fa0977cd09cb562b7bfd07907d5c7f", "commit_rev": "c9f4901df35a0284fd519c3d9f408303018d18b3"}
Message was sent while issue was closed.
Description was changed from ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. TBR=junov@chromium.org BUG=662498 ========== to ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. TBR=junov@chromium.org BUG=662498 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. TBR=junov@chromium.org BUG=662498 ========== to ========== Update Resize information from OffscreenCanvas to OffscreenCanvasFrameDispatcher In addition to that, this CL makes OffscreenCanvasFrameDispatcher own FrameSinkId only, because the localFrameId will be changed in resizing workflow. TBR=junov@chromium.org BUG=662498 Committed: https://crrev.com/454256046619fba9e01a6a1f32ed4dd649ae6553 Cr-Commit-Position: refs/heads/master@{#434308} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/454256046619fba9e01a6a1f32ed4dd649ae6553 Cr-Commit-Position: refs/heads/master@{#434308}
Message was sent while issue was closed.
lgtm |