Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2517343002: Make indexed_db.mojom.BlobInfo.size a signed integer. (Closed)

Created:
4 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
kenrb, cmumford
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, cmumford, darin (slow to review), darin-cc_chromium.org, jam, jsbell+idb_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make indexed_db.mojom.BlobInfo.size a signed integer. This field uses -1 as a flag value so it should not be unsigned. BUG=627484 Committed: https://crrev.com/72e3170856eaccb3e827d856d468da3497fc3aea Cr-Commit-Position: refs/heads/master@{#433986}

Patch Set 1 #

Patch Set 2 : Remove static cast in indexed_db_backing_store.cc:739. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/indexed_db/database_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/indexed_db.mojom View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (12 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 1 month ago (2016-11-21 22:20:57 UTC) #2
cmumford
Can you remove the static_cast in indexed_db_backing_store.cc:739
4 years, 1 month ago (2016-11-22 17:26:51 UTC) #7
Reilly Grant (use Gerrit)
On 2016/11/22 at 17:26:51, cmumford wrote: > Can you remove the static_cast in indexed_db_backing_store.cc:739 Done.
4 years, 1 month ago (2016-11-22 18:08:45 UTC) #8
Reilly Grant (use Gerrit)
Remove static cast in indexed_db_backing_store.cc:739.
4 years, 1 month ago (2016-11-22 18:08:55 UTC) #9
cmumford
lgtm
4 years, 1 month ago (2016-11-22 18:15:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343002/20001
4 years, 1 month ago (2016-11-22 18:37:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/310667)
4 years, 1 month ago (2016-11-22 18:46:02 UTC) #14
kenrb
ipc lgtm
4 years, 1 month ago (2016-11-22 18:57:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343002/20001
4 years, 1 month ago (2016-11-22 19:12:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/185923)
4 years, 1 month ago (2016-11-22 20:08:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517343002/20001
4 years, 1 month ago (2016-11-22 21:05:41 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 21:34:19 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 21:36:48 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72e3170856eaccb3e827d856d468da3497fc3aea
Cr-Commit-Position: refs/heads/master@{#433986}

Powered by Google App Engine
This is Rietveld 408576698