Report invalid blob file paths from the IO thread.

Report invalid blob file paths from the IO thread.

We shouldn't be calling bad_message::ReceivedBadMessage now that
messages are sent with Mojo and especially not from the IDB thread.
This patch switches to using mojo::ReportBadMessage and does the
validation on the IO thread in the context of processing the Mojo
message.

BUG=

Committed: https://crrev.com/43c6bce3df6ed4666be61577359003dfad63ac92
Cr-Commit-Position: refs/heads/master@{#433668}

[Reilly Grant (use Gerrit), 2016-11-21 19:32:27]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2016-11-21 19:33:07]

reillyg@chromium.org changed reviewers:
+ cmumford@chromium.org

[Reilly Grant (use Gerrit), 2016-11-21 19:33:07]

Please take a look. I will likely have to merge this to M-56.

[commit-bot: I haz the power, 2016-11-21 19:33:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:33:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:33:53]

Dry run: This issue passed the CQ dry run.

[cmumford, 2016-11-21 21:11:56]

lgtm

You should probably enter a bug now if you want to get it merged.

I don't see any reason to fix signed/unsigned type for size in this CL, but we
should consider fixing this.

https://codereview.chromium.org/2516303004/diff/1/content/browser/indexed_db/...
File content/browser/indexed_db/database_impl.cc (right):

https://codereview.chromium.org/2516303004/diff/1/content/browser/indexed_db/...
content/browser/indexed_db/database_impl.cc:283: if (info->size !=
static_cast<uint64_t>(-1)) {
Why is BlobInfo.size currently an unsigned 64-bit int? WebBlobInfo.size is
signed, and so is IndexedDBBlobInfo.

[Reilly Grant (use Gerrit), 2016-11-21 22:00:32]

I'll create a follow-up for the sign issue. I realized after sending this out
that this wasn't as bad an issue as I thought it was. No need to do a merge and
now the code is more correct.

[Reilly Grant (use Gerrit), 2016-11-21 22:00:39]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-11-21 22:01:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 22:17:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479765639988920, "parent_rev":
"4cff60794460795c5722b859c610e2058016919c", "commit_rev":
"b59b0c953872cbb7b8bc4c4570c720688857961c"}

[commit-bot: I haz the power, 2016-11-21 22:18:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 22:20:58]

Description was changed from

==========
Report invalid blob file paths from the IO thread.

We shouldn't be calling bad_message::ReceivedBadMessage now that
messages are sent with Mojo and especially not from the IDB thread.
This patch switches to using mojo::ReportBadMessage and does the
validation on the IO thread in the context of processing the Mojo
message.

BUG=
==========

to

==========
Report invalid blob file paths from the IO thread.

We shouldn't be calling bad_message::ReceivedBadMessage now that
messages are sent with Mojo and especially not from the IDB thread.
This patch switches to using mojo::ReportBadMessage and does the
validation on the IO thread in the context of processing the Mojo
message.

BUG=

Committed: https://crrev.com/43c6bce3df6ed4666be61577359003dfad63ac92
Cr-Commit-Position: refs/heads/master@{#433668}
==========

[commit-bot: I haz the power, 2016-11-21 22:20:59]

Patchset 1 (id:??) landed as
https://crrev.com/43c6bce3df6ed4666be61577359003dfad63ac92
Cr-Commit-Position: refs/heads/master@{#433668}