Remove dropped frame counting and task posting from VideoFrameCompositor.

Remove dropped frame counting and task posting from VideoFrameCompositor.

While developing VideoFrameScheduler it became apparent that we no longer need to post tasks to notify the compositor as scheduling is already being done on the compositor thread. If there are no posted tasks, it also means we don't need to track dropped frames due to missed scheduler notifications.

BUG=110814
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266822

[scherkus (not reviewing), 2014-04-25 23:18:37]

here's a CL pulled off from https://codereview.chromium.org/237353007/

[xhwang, 2014-04-28 06:42:59]

Looking good in general. Just two comments asking for more comments :)

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
File content/renderer/media/video_frame_compositor.cc (right):

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
content/renderer/media/video_frame_compositor.cc:70: }
These two "if" blocks use different logic. It'd be nice to have a comment about
why.

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
File content/renderer/media/video_frame_compositor.h (right):

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
content/renderer/media/video_frame_compositor.h:28: // VideoFrameCompositor must
live on the same thread as the compositor.
Can you add more comments about threading? It seems VFC must live on a single
thread (the compositor thread), but you have a |lock_| to protect the
|current_frame_|.

[scherkus (not reviewing), 2014-04-28 16:59:46]

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
File content/renderer/media/video_frame_compositor.cc (right):

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
content/renderer/media/video_frame_compositor.cc:70: }
On 2014/04/28 06:42:59, xhwang wrote:
> These two "if" blocks use different logic. It'd be nice to have a comment
about
> why.

there's a comment in the .h with a TODO that talks about the inconsistency
between the two

do you feel that's adequate, or would you rather move it here / duplicate it
here?

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
File content/renderer/media/video_frame_compositor.h (right):

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
content/renderer/media/video_frame_compositor.h:28: // VideoFrameCompositor must
live on the same thread as the compositor.
On 2014/04/28 06:42:59, xhwang wrote:
> Can you add more comments about threading? It seems VFC must live on a single
> thread (the compositor thread), but you have a |lock_| to protect the
> |current_frame_|.

Done.

[xhwang, 2014-04-28 17:15:34]

lgtm

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
File content/renderer/media/video_frame_compositor.cc (right):

https://codereview.chromium.org/251733005/diff/1/content/renderer/media/video...
content/renderer/media/video_frame_compositor.cc:70: }
On 2014/04/28 16:59:47, scherkus wrote:
> On 2014/04/28 06:42:59, xhwang wrote:
> > These two "if" blocks use different logic. It'd be nice to have a comment
> about
> > why.
> 
> there's a comment in the .h with a TODO that talks about the inconsistency
> between the two
> 
> do you feel that's adequate, or would you rather move it here / duplicate it
> here?

okay, I missed that one.

[scherkus (not reviewing), 2014-04-28 17:30:13]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:30:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/251733005/20001

[commit-bot: I haz the power, 2014-04-28 18:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:37:23]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[scherkus (not reviewing), 2014-04-28 18:41:34]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/251733005/20001

[commit-bot: I haz the power, 2014-04-28 20:28:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:28:55]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[scherkus (not reviewing), 2014-04-28 20:38:46]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:39:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/251733005/40001

[commit-bot: I haz the power, 2014-04-28 21:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:24:29]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[scherkus (not reviewing), 2014-04-28 23:01:14]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:02:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/251733005/40001

[commit-bot: I haz the power, 2014-04-28 23:39:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:39:07]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[scherkus (not reviewing), 2014-04-29 00:30:00]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-29 00:30:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/251733005/40001

[commit-bot: I haz the power, 2014-04-29 01:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:18:36]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[scherkus (not reviewing), 2014-04-29 01:31:34]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:33:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/251733005/40001

[commit-bot: I haz the power, 2014-04-29 10:06:59]

Change committed as 266822