Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2517313002: Merge M56: "Add audio only watch time metrics." (Closed)

Created:
4 years, 1 month ago by DaleCurtis
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge M56: "Add audio only watch time metrics." Enables tracking of audio only "watch time" histograms. They are the same as the audio+video ones except there is no requirement on visibility or video size for recording watch time. BUG=633743 TEST=new audio only unittests. Review-Url: https://codereview.chromium.org/2498113004 Cr-Commit-Position: refs/heads/master@{#433102} (cherry picked from commit 051d5b8e2973c0f253ade88303b467a043530d23) Committed: https://chromium.googlesource.com/chromium/src/+/7c02dce64f7c158bee54e9f161bfffd71d45d2dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -142 lines) Patch
M content/browser/media/media_internals.cc View 5 chunks +44 lines, -13 lines 0 comments Download
M media/base/media_log.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/media_log.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M media/blink/watch_time_reporter.h View 1 chunk +10 lines, -11 lines 0 comments Download
M media/blink/watch_time_reporter.cc View 4 chunks +30 lines, -11 lines 0 comments Download
M media/blink/watch_time_reporter_unittest.cc View 16 chunks +172 lines, -107 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 1 month ago (2016-11-21 20:30:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c02dce64f7c158bee54e9f161bfffd71d45d2dc.

Powered by Google App Engine
This is Rietveld 408576698