Add audio only watch time metrics.

Add audio only watch time metrics.

Enables tracking of audio only "watch time" histograms. They are
the same as the audio+video ones except there is no requirement
on visibility or video size for recording watch time.

BUG=633743
TEST=new audio only unittests.

Committed: https://crrev.com/051d5b8e2973c0f253ade88303b467a043530d23
Cr-Commit-Position: refs/heads/master@{#433102}

[DaleCurtis, 2016-11-17 20:24:00]

dalecurtis@chromium.org changed reviewers:
+ holte@chromium.org, sandersd@chromium.org

[DaleCurtis, 2016-11-17 20:24:01]

Working on adding more tests now, but this is otherwise fully functional.

+holte for histograms.xml

[sandersd (OOO until July 31), 2016-11-17 21:10:37]

lgtm

https://codereview.chromium.org/2498113004/diff/1/media/blink/watch_time_repo...
File media/blink/watch_time_reporter.h (right):

https://codereview.chromium.org/2498113004/diff/1/media/blink/watch_time_repo...
media/blink/watch_time_reporter.h:25: // foreground (video only) media must be
watched to start watch time monitoring.
Nit: Perhaps say 'when there is video' instead of 'video only'?

[Steven Holte, 2016-11-17 21:29:45]

lgtm

[DaleCurtis, 2016-11-17 22:16:29]

Patchset #2 (id:20001) has been deleted

[DaleCurtis, 2016-11-17 22:17:33]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-11-17 22:17:34]

Thanks for the review. Rewrote the tests as parameterized so audio-only gets all
the same coverage and added a test to ensure Shown/Hidden doesn't affect
audio-only.

https://codereview.chromium.org/2498113004/diff/1/media/blink/watch_time_repo...
File media/blink/watch_time_reporter.h (right):

https://codereview.chromium.org/2498113004/diff/1/media/blink/watch_time_repo...
media/blink/watch_time_reporter.h:25: // foreground (video only) media must be
watched to start watch time monitoring.
On 2016/11/17 at 21:10:37, sandersd wrote:
> Nit: Perhaps say 'when there is video' instead of 'video only'?

Done.

[DaleCurtis, 2016-11-17 22:17:34]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2498113004/#ps40001
(title: "Comments and tests.")

[commit-bot: I haz the power, 2016-11-17 22:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 23:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 23:52:18]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[DaleCurtis, 2016-11-18 02:47:09]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:49:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:28:33]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-18 04:33:08]

Description was changed from

==========
Add audio only watch time metrics.

Enables tracking of audio only "watch time" histograms. They are
the same as the audio+video ones except there is no requirement
on visibility or video size for recording watch time.

BUG=633743
TEST=new audio only unittests.
==========

to

==========
Add audio only watch time metrics.

Enables tracking of audio only "watch time" histograms. They are
the same as the audio+video ones except there is no requirement
on visibility or video size for recording watch time.

BUG=633743
TEST=new audio only unittests.

Committed: https://crrev.com/051d5b8e2973c0f253ade88303b467a043530d23
Cr-Commit-Position: refs/heads/master@{#433102}
==========

[commit-bot: I haz the power, 2016-11-18 04:33:09]

Patchset 2 (id:??) landed as
https://crrev.com/051d5b8e2973c0f253ade88303b467a043530d23
Cr-Commit-Position: refs/heads/master@{#433102}