Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2498113004: Add audio only watch time metrics. (Closed)

Created:
4 years, 1 month ago by DaleCurtis
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add audio only watch time metrics. Enables tracking of audio only "watch time" histograms. They are the same as the audio+video ones except there is no requirement on visibility or video size for recording watch time. BUG=633743 TEST=new audio only unittests. Committed: https://crrev.com/051d5b8e2973c0f253ade88303b467a043530d23 Cr-Commit-Position: refs/heads/master@{#433102}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments and tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -142 lines) Patch
M content/browser/media/media_internals.cc View 5 chunks +44 lines, -13 lines 0 comments Download
M media/base/media_log.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/media_log.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M media/blink/watch_time_reporter.h View 1 1 chunk +10 lines, -11 lines 0 comments Download
M media/blink/watch_time_reporter.cc View 4 chunks +30 lines, -11 lines 0 comments Download
M media/blink/watch_time_reporter_unittest.cc View 1 16 chunks +172 lines, -107 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
DaleCurtis
Working on adding more tests now, but this is otherwise fully functional. +holte for histograms.xml
4 years, 1 month ago (2016-11-17 20:24:01 UTC) #2
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/2498113004/diff/1/media/blink/watch_time_reporter.h File media/blink/watch_time_reporter.h (right): https://codereview.chromium.org/2498113004/diff/1/media/blink/watch_time_reporter.h#newcode25 media/blink/watch_time_reporter.h:25: // foreground (video only) media must be watched ...
4 years, 1 month ago (2016-11-17 21:10:37 UTC) #3
Steven Holte
lgtm
4 years, 1 month ago (2016-11-17 21:29:45 UTC) #4
DaleCurtis
Thanks for the review. Rewrote the tests as parameterized so audio-only gets all the same ...
4 years, 1 month ago (2016-11-17 22:17:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498113004/40001
4 years, 1 month ago (2016-11-17 22:19:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/338223)
4 years, 1 month ago (2016-11-17 23:52:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498113004/40001
4 years, 1 month ago (2016-11-18 02:49:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-18 04:28:33 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:33:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/051d5b8e2973c0f253ade88303b467a043530d23
Cr-Commit-Position: refs/heads/master@{#433102}

Powered by Google App Engine
This is Rietveld 408576698