|
|
Chromium Code Reviews
DescriptionReland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ )
Reason for revert:
This turned out not to be the cause of the regression in draw properties computation time.
Original issue's description:
> Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ )
>
> Reason for revert:
> Possibly caused a regression in draw properties computation time (see http://crbug.com/663068).
>
> Original issue's description:
> > cc: Remove more references to owning_layer_ from RenderSurfaceImpl
> >
> > This removes more dependencies of RenderSurfaceImpl on its owning layer.
> > Specifically, this removes the use of owning_layer_ for accessing
> > property trees and debug colors, and for gettng the surface's
> > effect tree index. This also renames the OwningLayerId() method to id().
> >
> > BUG=611883
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> >
> > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b
> > Cr-Commit-Position: refs/heads/master@{#428991}
>
> TBR=jaydasika@chromium.org,weiliangc@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=611883, 663068
>
> Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade
> Cr-Commit-Position: refs/heads/master@{#430419}
BUG=611883, 663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed: https://crrev.com/fa5b0164962353a8e0e3ad6597ee9723a1c51985
Cr-Commit-Position: refs/heads/master@{#434349}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Fix SPv2 layout test crashes #Patch Set 4 : Rebase #
Messages
Total messages: 41 (24 generated)
Created Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl
The CQ bit was checked by ajuma@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} TBR=jaydasika@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=611883,663068 ========== to ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} TBR=jaydasika@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=611883,663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by ajuma@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
LGTM
The CQ bit was checked by ajuma@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} TBR=jaydasika@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=611883,663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} BUG=611883,663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by ajuma@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:140001) has been deleted
ajuma@chromium.org changed reviewers: + pdr@chromium.org
+pdr for PaintArtifactCompositor This was failing some SPv2 layout tests because cc::PropertyTrees' maps from stable id (currently owner_id) to index weren't getting set up.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/11/23 at 18:05:31, ajuma wrote: > +pdr for PaintArtifactCompositor > > This was failing some SPv2 layout tests because cc::PropertyTrees' maps from stable id (currently owner_id) to index weren't getting set up. Why does the reland have these changes but they weren't present before? Did a patch land between?
On 2016/11/23 19:28:27, pdr. wrote: > On 2016/11/23 at 18:05:31, ajuma wrote: > > +pdr for PaintArtifactCompositor > > > > This was failing some SPv2 layout tests because cc::PropertyTrees' maps from > stable id (currently owner_id) to index weren't getting set up. > > Why does the reland have these changes but they weren't present before? Did a > patch land between? Yes, https://codereview.chromium.org/2503193002 landed in between and exposed this by changing the effect tree so that node 1 has no parent rather than having parent 0 (so then the default value 0 returned by the empty map is the index of a node that is disconnected from the rest of the tree, and that leads to the crashes).
On 2016/11/23 at 21:12:50, ajuma wrote: > On 2016/11/23 19:28:27, pdr. wrote: > > On 2016/11/23 at 18:05:31, ajuma wrote: > > > +pdr for PaintArtifactCompositor > > > > > > This was failing some SPv2 layout tests because cc::PropertyTrees' maps from > > stable id (currently owner_id) to index weren't getting set up. > > > > Why does the reland have these changes but they weren't present before? Did a > > patch land between? > > Yes, https://codereview.chromium.org/2503193002 landed in between and exposed this by changing the effect tree so that node 1 has no parent rather than having parent 0 (so then the default value 0 returned by the empty map is the index of a node that is disconnected from the rest of the tree, and that leads to the crashes). LGTM
The CQ bit was checked by ajuma@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from weiliangc@chromium.org Link to the patchset: https://codereview.chromium.org/2517273002/#ps160001 (title: "Fix SPv2 layout test crashes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by ajuma@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org, weiliangc@chromium.org Link to the patchset: https://codereview.chromium.org/2517273002/#ps180001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by ajuma@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 180001, "attempt_start_ts": 1479996335642350,
"parent_rev": "533474f1b84b6b720146eaad9d4c8a728d4de21c", "commit_rev":
"652dc90d0fa7b7b6f6b99613b47ed8fd64636041"}
Message was sent while issue was closed.
Description was changed from ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} BUG=611883,663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} BUG=611883,663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} BUG=611883,663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883,663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} BUG=611883,663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/fa5b0164962353a8e0e3ad6597ee9723a1c51985 Cr-Commit-Position: refs/heads/master@{#434349} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/fa5b0164962353a8e0e3ad6597ee9723a1c51985 Cr-Commit-Position: refs/heads/master@{#434349} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
