Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2517273002: Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (Closed)

Created:
4 years ago by ajuma
Modified:
4 years ago
Reviewers:
jaydasika, pdr., weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #1 id:1 of https://codereview.chromium.org/2483033002/ ) Reason for revert: This turned out not to be the cause of the regression in draw properties computation time. Original issue's description: > Revert of cc: Remove more references to owning_layer_ from RenderSurfaceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2460413003/ ) > > Reason for revert: > Possibly caused a regression in draw properties computation time (see http://crbug.com/663068). > > Original issue's description: > > cc: Remove more references to owning_layer_ from RenderSurfaceImpl > > > > This removes more dependencies of RenderSurfaceImpl on its owning layer. > > Specifically, this removes the use of owning_layer_ for accessing > > property trees and debug colors, and for gettng the surface's > > effect tree index. This also renames the OwningLayerId() method to id(). > > > > BUG=611883 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/740a49caf190bab13f8fdfd0979b29e09752da6b > > Cr-Commit-Position: refs/heads/master@{#428991} > > TBR=jaydasika@chromium.org,weiliangc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=611883, 663068 > > Committed: https://crrev.com/84667306ea7de0c234ad66737a3c519c21511ade > Cr-Commit-Position: refs/heads/master@{#430419} BUG=611883, 663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/fa5b0164962353a8e0e3ad6597ee9723a1c51985 Cr-Commit-Position: refs/heads/master@{#434349}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix SPv2 layout test crashes #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M cc/layers/render_surface_impl.h View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M cc/layers/render_surface_impl.cc View 1 2 3 9 chunks +14 lines, -19 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 3 9 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (24 generated)
ajuma
Created Reland of cc: Remove more references to owning_layer_ from RenderSurfaceImpl
4 years ago (2016-11-21 18:35:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517273002/1
4 years ago (2016-11-21 18:37:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/310088) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-11-21 18:40:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517273002/120001
4 years ago (2016-11-21 19:13:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/1852)
4 years ago (2016-11-21 21:18:44 UTC) #10
weiliangc
LGTM
4 years ago (2016-11-22 18:29:40 UTC) #11
ajuma
+pdr for PaintArtifactCompositor This was failing some SPv2 layout tests because cc::PropertyTrees' maps from stable ...
4 years ago (2016-11-23 18:05:31 UTC) #19
pdr.
On 2016/11/23 at 18:05:31, ajuma wrote: > +pdr for PaintArtifactCompositor > > This was failing ...
4 years ago (2016-11-23 19:28:27 UTC) #22
ajuma
On 2016/11/23 19:28:27, pdr. wrote: > On 2016/11/23 at 18:05:31, ajuma wrote: > > +pdr ...
4 years ago (2016-11-23 21:12:50 UTC) #23
pdr.
On 2016/11/23 at 21:12:50, ajuma wrote: > On 2016/11/23 19:28:27, pdr. wrote: > > On ...
4 years ago (2016-11-23 21:53:51 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517273002/160001
4 years ago (2016-11-23 22:02:54 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 00:11:27 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517273002/180001
4 years ago (2016-11-24 01:11:16 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 03:13:32 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517273002/180001
4 years ago (2016-11-24 14:06:24 UTC) #36
commit-bot: I haz the power
Committed patchset #4 (id:180001)
4 years ago (2016-11-24 16:45:18 UTC) #39
commit-bot: I haz the power
4 years ago (2016-11-24 16:47:43 UTC) #41
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fa5b0164962353a8e0e3ad6597ee9723a1c51985
Cr-Commit-Position: refs/heads/master@{#434349}

Powered by Google App Engine
This is Rietveld 408576698