Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2503193002: [SPv2] Refactor PaintArtifactorCompositor root node creation (Closed)

Created:
4 years, 1 month ago by trchen
Modified:
4 years, 1 month ago
Reviewers:
pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Refactor PaintArtifactorCompositor root node creation This CL sets up static conversion for root blink property nodes into the hardcoded cc property nodes number 1 (a.k.a. secondary root). Now we also enforce that every blink-created property node can never refer to nullptr nodes. BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/c2fccd350841d0d60631a7196c1bb9b0bf838255 Cr-Commit-Position: refs/heads/master@{#432677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -125 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 7 chunks +86 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 18 chunks +121 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestPaintArtifact.h View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
trchen
Disallow nullptr property nodes everywhere!
4 years, 1 month ago (2016-11-16 03:30:44 UTC) #3
pdr.
LGTM, nice cleanup
4 years, 1 month ago (2016-11-16 03:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503193002/1
4 years, 1 month ago (2016-11-16 23:51:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 00:31:25 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 00:41:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2fccd350841d0d60631a7196c1bb9b0bf838255
Cr-Commit-Position: refs/heads/master@{#432677}

Powered by Google App Engine
This is Rietveld 408576698