Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2517253002: Drop down list closes on touch scroll/pinch zoom (Closed)
Patch Set: review comments addressed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 1330049612f6d59aee3d227ebb56d73fec288375..c8d306195c4d5f32c44c4d36072f4e92f107a077 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -904,6 +904,10 @@ WebInputEventResult WebViewImpl::handleGestureEvent(
case WebInputEvent::GestureShowPress:
m_client->cancelScheduledContentIntents();
case WebInputEvent::GestureTapDown:
+ // Touch pinch zoom and scroll must hide the popup. In case of a touch
+ // scroll or pinch zoom, this function is called with GestureTapDown
+ // rather than a GSB/GSU/GSE or GPB/GPU/GPE.
+ hidePopups();
case WebInputEvent::GestureTapCancel:
case WebInputEvent::GestureTapUnconfirmed: {
eventResult = mainFrameImpl()->frame()->eventHandler().handleGestureEvent(
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698