Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2517253002: Drop down list closes on touch scroll/pinch zoom (Closed)
Patch Set: review comments addressed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 2b83ad5714484f6cab641241da89f1eebb9ea2b2..9f4e2d9c7e3c0d8522aa49742ad273b0f0658e73 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -457,7 +457,8 @@ WebInputEventResult WebPagePopupImpl::handleGestureEvent(
if (m_closing || !m_page || !m_page->mainFrame() ||
!toLocalFrame(m_page->mainFrame())->view())
return WebInputEventResult::NotHandled;
- if (event.type == WebInputEvent::GestureTap &&
+ if ((event.type == WebInputEvent::GestureTap ||
+ event.type == WebInputEvent::GestureTapDown) &&
!isViewportPointInWindow(event.x, event.y)) {
cancel();
return WebInputEventResult::NotHandled;
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698