Drop down list closes on touch scroll/pinch zoom

third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html

Index: third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html b/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
index 71d3e8ca11d4f0a6f6c5fe78a98d69d9bb0f7dc8..c1985ac15e0f3a26b1a036c262469000225ddc0c 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
+++ b/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
@@ -146,8 +146,28 @@ function test2AfterScrollEvent() {
     shouldNotBe('window.internals.pagePopupWindow', 'null');
     shouldBeEqualToString('menuElement2.value', '2');
 
-    finishJSTest();
+    test3();
 }
+
+function test3() {
+    debug("==> Test popup closes on outside GestureTapDawn");
+    eventSender.clearTouchPoints();
+    openPicker(menuElement, function () {
+        eventSender.addTouchPoint(300, 300);
+        eventSender.touchStart(300, 300);
+        eventSender.gestureTapDown(300, 300);

[bokan, 2016/11/21 20:14:36]

We seem to be doing both a touch move and a gesture tap, what's the intention
here? If we want to make sure both close the popup, we should have separate
tests for each.

Also, the description says we close on pinch-zoom or gesture scroll. We don't
generate either here.

[sahel, 2016/11/21 20:41:44]

I can get rid of the touch move, here.
I used GestureTapDown instead of a GS/GP event, because in both WebViewImpl.cpp
and WebPagePopupImpl.cpp, handleGestureEvent is called with GestureTapDown in
case of a touch scroll/pinch zoom. handleGestureEvent gets called before
generating GS or GP events from touch info.

[bokan, 2016/11/22 16:00:08]

Ok, just get rid of everything but the GestureTapDown then.

[sahel, 2016/11/24 15:29:25]

Done.

+        eventSender.touchMove(300, 400);
+        eventSender.releaseTouchPoint(0);
+        eventSender.touchEnd(300, 400);
+        shouldBeNull('window.internals.pagePopupWindow');
+        finishJSTest();
+    }, function () {
+        testFailed('picker didn\'t open')
+        finishJSTest();
+    });
+}
+
+
 </script>
 </body>
 </html>