third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html - Issue 2517253002: Drop down list closes on touch scroll/pinch zoom

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html

Issue 2517253002: Drop down list closes on touch scroll/pinch zoom (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 <script src="../resources/common.js"></script>	5 <script src="../resources/common.js"></script>

6 <script src="../resources/picker-common.js"></script>	6 <script src="../resources/picker-common.js"></script>

7 </head>	7 </head>

8 <body>	8 <body>

9 <select id="menu">	9 <select id="menu">

10 <option>foo</option>	10 <option>foo</option>

(...skipping 128 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
139 function test2AfterScrollEvent() {	139 function test2AfterScrollEvent() {

140 // touchmove event fires before the scroll event so the selection will chang e.	140 // touchmove event fires before the scroll event so the selection will chang e.

141 shouldBeEqualToString('picker._selectElement.value', '0');	141 shouldBeEqualToString('picker._selectElement.value', '0');

142 eventSender.releaseTouchPoint(0);	142 eventSender.releaseTouchPoint(0);

143 eventSender.touchEnd();	143 eventSender.touchEnd();

144 eventSender.gestureScrollEnd(0, 0);	144 eventSender.gestureScrollEnd(0, 0);

145	145

146 shouldNotBe('window.internals.pagePopupWindow', 'null');	146 shouldNotBe('window.internals.pagePopupWindow', 'null');

147 shouldBeEqualToString('menuElement2.value', '2');	147 shouldBeEqualToString('menuElement2.value', '2');

148	148

149 finishJSTest();	149 test3();

150 }	150 }

	151

	152 function test3() {

	153 debug("==> Test popup closes on outside GestureTapDawn");

	154 eventSender.clearTouchPoints();

	155 openPicker(menuElement, function () {

	156 eventSender.addTouchPoint(300, 300);

	157 eventSender.touchStart(300, 300);

	158 eventSender.gestureTapDown(300, 300);
	bokan 2016/11/21 20:14:36 We seem to be doing both a touch move and a gestur We seem to be doing both a touch move and a gesture tap, what's the intention here? If we want to make sure both close the popup, we should have separate tests for each. Also, the description says we close on pinch-zoom or gesture scroll. We don't generate either here. sahel 2016/11/21 20:41:44 I can get rid of the touch move, here. I used Gest Show quoted text On 2016/11/21 20:14:36, bokan wrote: > We seem to be doing both a touch move and a gesture tap, what's the intention > here? If we want to make sure both close the popup, we should have separate > tests for each. > > Also, the description says we close on pinch-zoom or gesture scroll. We don't > generate either here. I can get rid of the touch move, here. I used GestureTapDown instead of a GS/GP event, because in both WebViewImpl.cpp and WebPagePopupImpl.cpp, handleGestureEvent is called with GestureTapDown in case of a touch scroll/pinch zoom. handleGestureEvent gets called before generating GS or GP events from touch info. bokan 2016/11/22 16:00:08 Ok, just get rid of everything but the GestureTapD Show quoted text On 2016/11/21 20:41:44, sahel wrote: > On 2016/11/21 20:14:36, bokan wrote: > > We seem to be doing both a touch move and a gesture tap, what's the intention > > here? If we want to make sure both close the popup, we should have separate > > tests for each. > > > > Also, the description says we close on pinch-zoom or gesture scroll. We don't > > generate either here. > > I can get rid of the touch move, here. > I used GestureTapDown instead of a GS/GP event, because in both WebViewImpl.cpp > and WebPagePopupImpl.cpp, handleGestureEvent is called with GestureTapDown in > case of a touch scroll/pinch zoom. handleGestureEvent gets called before > generating GS or GP events from touch info. Ok, just get rid of everything but the GestureTapDown then. sahel 2016/11/24 15:29:25 Done. Show quoted text On 2016/11/22 16:00:08, bokan wrote: > On 2016/11/21 20:41:44, sahel wrote: > > On 2016/11/21 20:14:36, bokan wrote: > > > We seem to be doing both a touch move and a gesture tap, what's the > intention > > > here? If we want to make sure both close the popup, we should have separate > > > tests for each. > > > > > > Also, the description says we close on pinch-zoom or gesture scroll. We > don't > > > generate either here. > > > > I can get rid of the touch move, here. > > I used GestureTapDown instead of a GS/GP event, because in both > WebViewImpl.cpp > > and WebPagePopupImpl.cpp, handleGestureEvent is called with GestureTapDown in > > case of a touch scroll/pinch zoom. handleGestureEvent gets called before > > generating GS or GP events from touch info. > > Ok, just get rid of everything but the GestureTapDown then. Done.
	159 eventSender.touchMove(300, 400);

	160 eventSender.releaseTouchPoint(0);

	161 eventSender.touchEnd(300, 400);

	162 shouldBeNull('window.internals.pagePopupWindow');

	163 finishJSTest();

	164 }, function () {

	165 testFailed('picker didn\'t open')

	166 finishJSTest();

	167 });

	168 }

	169

	170

151 </script>	171 </script>

152 </body>	172 </body>

153 </html>	173 </html>

OLD	NEW