Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2517153003: Add unit test for fdrm's MD5 (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -28 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/fdrm/crypto/fx_crypt.h View 1 chunk +6 lines, -0 lines 0 comments Download
M core/fdrm/crypto/fx_crypt.cpp View 6 chunks +5 lines, -10 lines 0 comments Download
A core/fdrm/crypto/fx_crypt_unittest.cpp View 1 1 chunk +200 lines, -0 lines 0 comments Download
M core/fpdfapi/parser/cpdf_security_handler.cpp View 3 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, Lei, for review.
4 years, 1 month ago (2016-11-21 19:34:09 UTC) #4
dsinclair
lgtm w/ nit. https://codereview.chromium.org/2517153003/diff/1/core/fdrm/crypto/fx_crypt_unittest.cpp File core/fdrm/crypto/fx_crypt_unittest.cpp (right): https://codereview.chromium.org/2517153003/diff/1/core/fdrm/crypto/fx_crypt_unittest.cpp#newcode1 core/fdrm/crypto/fx_crypt_unittest.cpp:1: // Copyright (c) 2011 The Chromium ...
4 years, 1 month ago (2016-11-21 19:37:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517153003/20001
4 years, 1 month ago (2016-11-21 19:52:44 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 20:08:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/f5cabbfc3085a7a7a3451452c1a7ebe1f19c...

Powered by Google App Engine
This is Rietveld 408576698