Remove some leftovers of full-codegen's generators implementation.

Remove some leftovers of full-codegen's generators implementation.

TBR=littledan@chromium.org
BUG=

Committed: https://crrev.com/c051ef383d1c97ec46b23efdd498469c70249ba5
Cr-Commit-Position: refs/heads/master@{#41180}

[neis, 2016-11-21 15:17:30]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 15:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-11-21 15:21:18]

neis@chromium.org changed reviewers:
+ mstarzinger@chromium.org, yangguo@chromium.org

[neis, 2016-11-21 15:21:19]

ptal

[neis, 2016-11-21 15:47:19]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 15:47:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 15:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 15:51:56]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[neis, 2016-11-21 15:53:36]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 15:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-11-21 15:56:16]

LGTM from my end, if Yang is fine with the TODOs in the debugger.

https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:19755: code_offset = Smi::cast(input_or_debug_pos())->value();
nit: Declaration and definition of {code_offset} can go into one line now.

https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:19759: code =
AbstractCode::cast(function()->shared()->bytecode_array());
nit: Declaration and definition of {code} can go into one line now.

https://codereview.chromium.org/2517143003/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2517143003/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:2493: // machine code produced for generators relies on
this forced context
nit: s/machine code/code/ here because it is technically bytecode that is being
produced.

[commit-bot: I haz the power, 2016-11-21 16:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 16:19:42]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-11-22 06:47:28]

On 2016/11/21 15:56:16, Michael Starzinger wrote:
> LGTM from my end, if Yang is fine with the TODOs in the debugger.
> 
> https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc
> File src/objects.cc (right):
> 
>
https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc#newcode1...
> src/objects.cc:19755: code_offset = Smi::cast(input_or_debug_pos())->value();
> nit: Declaration and definition of {code_offset} can go into one line now.
> 
>
https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc#newcode1...
> src/objects.cc:19759: code =
> AbstractCode::cast(function()->shared()->bytecode_array());
> nit: Declaration and definition of {code} can go into one line now.
> 
> https://codereview.chromium.org/2517143003/diff/20001/src/parsing/parser.cc
> File src/parsing/parser.cc (right):
> 
>
https://codereview.chromium.org/2517143003/diff/20001/src/parsing/parser.cc#n...
> src/parsing/parser.cc:2493: // machine code produced for generators relies on
> this forced context
> nit: s/machine code/code/ here because it is technically bytecode that is
being
> produced.

awesome. lgtm.

[neis, 2016-11-22 13:18:54]

https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:19755: code_offset = Smi::cast(input_or_debug_pos())->value();
On 2016/11/21 15:56:16, Michael Starzinger wrote:
> nit: Declaration and definition of {code_offset} can go into one line now.

Done.

https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:19759: code =
AbstractCode::cast(function()->shared()->bytecode_array());
On 2016/11/21 15:56:16, Michael Starzinger wrote:
> nit: Declaration and definition of {code} can go into one line now.

Done.

https://codereview.chromium.org/2517143003/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2517143003/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:2493: // machine code produced for generators relies on
this forced context
On 2016/11/21 15:56:16, Michael Starzinger wrote:
> nit: s/machine code/code/ here because it is technically bytecode that is
being
> produced.

Done.

[neis, 2016-11-22 13:20:34]

The CQ bit was checked by neis@chromium.org

[neis, 2016-11-22 13:20:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2517143003/#ps60001
(title: "Address feedback.")

[commit-bot: I haz the power, 2016-11-22 13:20:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 13:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 13:24:21]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/29108)

[neis, 2016-11-22 13:30:02]

Description was changed from

==========
Remove some leftovers of full-codegen's generators implementation.

BUG=
==========

to

==========
Remove some leftovers of full-codegen's generators implementation.

TBR=littledan@chromium.org
BUG=
==========

[neis, 2016-11-22 13:30:08]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-11-22 13:30:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 13:48:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479821408511150,
"parent_rev": "572358a376a6d75558c595797ac755f8869a555f", "commit_rev":
"f1132fccefc6728036fd17c93da99129f0b7965b"}

[commit-bot: I haz the power, 2016-11-22 13:48:37]

Description was changed from

==========
Remove some leftovers of full-codegen's generators implementation.

TBR=littledan@chromium.org
BUG=
==========

to

==========
Remove some leftovers of full-codegen's generators implementation.

TBR=littledan@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-11-22 13:48:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-22 13:49:08]

Description was changed from

==========
Remove some leftovers of full-codegen's generators implementation.

TBR=littledan@chromium.org
BUG=
==========

to

==========
Remove some leftovers of full-codegen's generators implementation.

TBR=littledan@chromium.org
BUG=

Committed: https://crrev.com/c051ef383d1c97ec46b23efdd498469c70249ba5
Cr-Commit-Position: refs/heads/master@{#41180}
==========

[commit-bot: I haz the power, 2016-11-22 13:49:09]

Patchset 4 (id:??) landed as
https://crrev.com/c051ef383d1c97ec46b23efdd498469c70249ba5
Cr-Commit-Position: refs/heads/master@{#41180}