Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2517143003: Remove some leftovers of full-codegen's generators implementation. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove some leftovers of full-codegen's generators implementation. TBR=littledan@chromium.org BUG= Committed: https://crrev.com/c051ef383d1c97ec46b23efdd498469c70249ba5 Cr-Commit-Position: refs/heads/master@{#41180}

Patch Set 1 #

Patch Set 2 : GENERATOR_CONTINUATION in arm64 #

Total comments: 6

Patch Set 3 : yes #

Patch Set 4 : Address feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -106 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/assembler.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/assembler.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M src/debug/debug.cc View 2 chunks +5 lines, -18 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +8 lines, -18 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/s390/assembler-s390.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
neis
ptal
4 years, 1 month ago (2016-11-21 15:21:19 UTC) #4
Michael Starzinger
LGTM from my end, if Yang is fine with the TODOs in the debugger. https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc ...
4 years, 1 month ago (2016-11-21 15:56:16 UTC) #11
Yang
On 2016/11/21 15:56:16, Michael Starzinger wrote: > LGTM from my end, if Yang is fine ...
4 years, 1 month ago (2016-11-22 06:47:28 UTC) #14
neis
https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/2517143003/diff/20001/src/objects.cc#newcode19755 src/objects.cc:19755: code_offset = Smi::cast(input_or_debug_pos())->value(); On 2016/11/21 15:56:16, Michael Starzinger wrote: ...
4 years, 1 month ago (2016-11-22 13:18:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517143003/60001
4 years, 1 month ago (2016-11-22 13:20:50 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/29108)
4 years, 1 month ago (2016-11-22 13:24:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517143003/60001
4 years, 1 month ago (2016-11-22 13:30:18 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-22 13:48:38 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 13:49:09 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c051ef383d1c97ec46b23efdd498469c70249ba5
Cr-Commit-Position: refs/heads/master@{#41180}

Powered by Google App Engine
This is Rietveld 408576698