src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2517143003: Remove some leftovers of full-codegen's generators implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2517143003: Remove some leftovers of full-codegen's generators implementation. (Closed)

Patch Set: Address feedback. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index b279b9e1aaec48e30ac18aa7c407c6e81f2fea26..87840f7488af57253d099e6ad0a6a8f7d0a2ab7b 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -130,8 +130,6 @@ void FullCodeGenerator::Generate() {

{ Comment cmnt(masm_, "[ Allocate locals");

int locals_count = info->scope()->num_stack_slots();

- // Generators allocate locals, if any, in context slots.

- DCHECK(!IsGeneratorFunction(literal()->kind()) || locals_count == 0);

OperandStackDepthIncrement(locals_count);

if (locals_count == 1) {

__ push(Immediate(isolate()->factory()->undefined_value()));