Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2517133002: Revert of [Interpreter] Collect NumberOrOddball feedback in CompareOps. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Collect NumberOrOddball feedback in CompareOps. (patchset #2 id:20001 of https://codereview.chromium.org/2506283003/ ) Reason for revert: Turbofan doesn't do proper ToNumber conversions on NumberOrOddball equality conversions. BUG=v8:5660 Original issue's description: > [Interpreter] Collect NumberOrOddball feedback in CompareOps. > > Collect feedback for oddballs in the interpreter compare operations handlers. > This is important to ensure that we don't consider oddball comparisons as > generic, which prevents optimization. > > BUG=chromium:660947 > > Committed: https://crrev.com/721e74d9d942fd4f2e3392ea9626d9d404dbbbd0 > Cr-Commit-Position: refs/heads/master@{#41081} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:660947 Committed: https://crrev.com/bd93fa6ee2745732afe7d7564c7fecaa726cdac2 Cr-Commit-Position: refs/heads/master@{#41134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -45 lines) Patch
M src/globals.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +15 lines, -38 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rmcilroy
Created Revert of [Interpreter] Collect NumberOrOddball feedback in CompareOps.
4 years, 1 month ago (2016-11-21 11:45:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517133002/1
4 years, 1 month ago (2016-11-21 11:45:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 12:14:35 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 12:14:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd93fa6ee2745732afe7d7564c7fecaa726cdac2
Cr-Commit-Position: refs/heads/master@{#41134}

Powered by Google App Engine
This is Rietveld 408576698