Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/globals.h

Issue 2517133002: Revert of [Interpreter] Collect NumberOrOddball feedback in CompareOps. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_GLOBALS_H_ 5 #ifndef V8_GLOBALS_H_
6 #define V8_GLOBALS_H_ 6 #define V8_GLOBALS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 1223 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 kNumber = 0x3, 1234 kNumber = 0x3,
1235 kNumberOrOddball = 0x7, 1235 kNumberOrOddball = 0x7,
1236 kString = 0x8, 1236 kString = 0x8,
1237 kAny = 0x1F 1237 kAny = 0x1F
1238 }; 1238 };
1239 }; 1239 };
1240 1240
1241 // Type feedback is encoded in such a way that, we can combine the feedback 1241 // Type feedback is encoded in such a way that, we can combine the feedback
1242 // at different points by performing an 'OR' operation. Type feedback moves 1242 // at different points by performing an 'OR' operation. Type feedback moves
1243 // to a more generic type when we combine feedback. 1243 // to a more generic type when we combine feedback.
1244 // kSignedSmall -> kNumber -> kNumberOrOddball -> kAny 1244 // kSignedSmall -> kNumber -> kAny
1245 // kString -> kAny 1245 // kString -> kAny
1246 // TODO(epertoso): consider unifying this with BinaryOperationFeedback. 1246 // TODO(epertoso): consider unifying this with BinaryOperationFeedback.
1247 class CompareOperationFeedback { 1247 class CompareOperationFeedback {
1248 public: 1248 public:
1249 enum { 1249 enum {
1250 kNone = 0x00, 1250 kNone = 0x00,
1251 kSignedSmall = 0x01, 1251 kSignedSmall = 0x01,
1252 kNumber = 0x3, 1252 kNumber = 0x3,
1253 kNumberOrOddball = 0x7, 1253 kString = 0x4,
1254 kString = 0x8, 1254 kAny = 0xf
1255 kAny = 0x1F
1256 }; 1255 };
1257 }; 1256 };
1258 1257
1259 // Describes how exactly a frame has been dropped from stack. 1258 // Describes how exactly a frame has been dropped from stack.
1260 enum LiveEditFrameDropMode { 1259 enum LiveEditFrameDropMode {
1261 // No frame has been dropped. 1260 // No frame has been dropped.
1262 LIVE_EDIT_FRAMES_UNTOUCHED, 1261 LIVE_EDIT_FRAMES_UNTOUCHED,
1263 // The top JS frame had been calling debug break slot stub. Patch the 1262 // The top JS frame had been calling debug break slot stub. Patch the
1264 // address this stub jumps to in the end. 1263 // address this stub jumps to in the end.
1265 LIVE_EDIT_FRAME_DROPPED_IN_DEBUG_SLOT_CALL, 1264 LIVE_EDIT_FRAME_DROPPED_IN_DEBUG_SLOT_CALL,
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
1309 } // namespace internal 1308 } // namespace internal
1310 } // namespace v8 1309 } // namespace v8
1311 1310
1312 // Used by js-builtin-reducer to identify whether ReduceArrayIterator() is 1311 // Used by js-builtin-reducer to identify whether ReduceArrayIterator() is
1313 // reducing a JSArray method, or a JSTypedArray method. 1312 // reducing a JSArray method, or a JSTypedArray method.
1314 enum class ArrayIteratorKind { kArray, kTypedArray }; 1313 enum class ArrayIteratorKind { kArray, kTypedArray };
1315 1314
1316 namespace i = v8::internal; 1315 namespace i = v8::internal;
1317 1316
1318 #endif // V8_GLOBALS_H_ 1317 #endif // V8_GLOBALS_H_
OLDNEW
« no previous file with comments | « no previous file | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698