Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2517103003:
Properly handle errors on server queries in Autofill. (Closed)
|
Created:
4 years, 1 month ago by Avi (use Gerrit) Modified:
4 years, 1 month ago CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionProperly handle errors on server queries in Autofill.
PersonalDataManager::OnWebDataServiceRequestDone originally only had pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error.
r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors.
BUG=659023
Committed: https://crrev.com/988a599c9d4426210a6c5a8164fef3dd6391dbdd
Cr-Commit-Position: refs/heads/master@{#433645}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + mathp@chromium.org
Description was changed from ========== Properly handle errors on server queries in Autofill. PersonalDataManager::OnWebDataServiceRequestDone originally only handled pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error. r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors. BUG=659023 ========== to ========== Properly handle errors on server queries in Autofill. PersonalDataManager::OnWebDataServiceRequestDone originally only had pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error. r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors. BUG=659023 ==========
vabr@chromium.org changed reviewers: + vabr@chromium.org
LGTM, thanks for investigating, finding, fixing and documenting this issue! Cheers, Vaclav
On 2016/11/21 19:09:58, vabr (Chromium) wrote: > LGTM, thanks for investigating, finding, fixing and documenting this issue! > > Cheers, > Vaclav NP, fingers crossed that this fixes our crash.
The CQ bit was unchecked by avi@chromium.org
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479759264635270, "parent_rev":
"9a345bbfe9bf236af2a691d013a06740691a2dba", "commit_rev":
"a579e43acf25c78e55ab20aea23e1df6e486340c"}
Message was sent while issue was closed.
Description was changed from ========== Properly handle errors on server queries in Autofill. PersonalDataManager::OnWebDataServiceRequestDone originally only had pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error. r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors. BUG=659023 ========== to ========== Properly handle errors on server queries in Autofill. PersonalDataManager::OnWebDataServiceRequestDone originally only had pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error. r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors. BUG=659023 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Properly handle errors on server queries in Autofill. PersonalDataManager::OnWebDataServiceRequestDone originally only had pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error. r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors. BUG=659023 ========== to ========== Properly handle errors on server queries in Autofill. PersonalDataManager::OnWebDataServiceRequestDone originally only had pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error. r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors. BUG=659023 Committed: https://crrev.com/988a599c9d4426210a6c5a8164fef3dd6391dbdd Cr-Commit-Position: refs/heads/master@{#433645} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/988a599c9d4426210a6c5a8164fef3dd6391dbdd Cr-Commit-Position: refs/heads/master@{#433645} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
