Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Side by Side Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 2517103003: Properly handle errors on server queries in Autofill. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/personal_data_manager.h" 5 #include "components/autofill/core/browser/personal_data_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <list> 10 #include <list>
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 tracked_objects::ScopedTracker tracking_profile( 342 tracked_objects::ScopedTracker tracking_profile(
343 FROM_HERE_WITH_EXPLICIT_FUNCTION( 343 FROM_HERE_WITH_EXPLICIT_FUNCTION(
344 "422460 PersonalDataManager::OnWebDataServiceRequestDone")); 344 "422460 PersonalDataManager::OnWebDataServiceRequestDone"));
345 345
346 if (!result) { 346 if (!result) {
347 // Error from the web database. 347 // Error from the web database.
348 if (h == pending_creditcards_query_) 348 if (h == pending_creditcards_query_)
349 pending_creditcards_query_ = 0; 349 pending_creditcards_query_ = 0;
350 else if (h == pending_profiles_query_) 350 else if (h == pending_profiles_query_)
351 pending_profiles_query_ = 0; 351 pending_profiles_query_ = 0;
352 else if (h == pending_server_creditcards_query_)
353 pending_server_creditcards_query_ = 0;
354 else if (h == pending_server_profiles_query_)
355 pending_server_profiles_query_ = 0;
352 return; 356 return;
353 } 357 }
354 358
355 switch (result->GetType()) { 359 switch (result->GetType()) {
356 case AUTOFILL_PROFILES_RESULT: 360 case AUTOFILL_PROFILES_RESULT:
357 if (h == pending_profiles_query_) { 361 if (h == pending_profiles_query_) {
358 ReceiveLoadedDbValues(h, result.get(), &pending_profiles_query_, 362 ReceiveLoadedDbValues(h, result.get(), &pending_profiles_query_,
359 &web_profiles_); 363 &web_profiles_);
360 LogProfileCount(); // This only logs local profiles. 364 LogProfileCount(); // This only logs local profiles.
361 } else { 365 } else {
(...skipping 1429 matching lines...) Expand 10 before | Expand all | Expand 10 after
1791 if (profile_to_merge->IsVerified()) 1795 if (profile_to_merge->IsVerified())
1792 break; 1796 break;
1793 } 1797 }
1794 } 1798 }
1795 } 1799 }
1796 AutofillMetrics::LogNumberOfProfilesRemovedDuringDedupe( 1800 AutofillMetrics::LogNumberOfProfilesRemovedDuringDedupe(
1797 profiles_to_delete->size()); 1801 profiles_to_delete->size());
1798 } 1802 }
1799 1803
1800 } // namespace autofill 1804 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698