Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 2517003003: Fix potential bug in push_test.js - do not cache subscription options (Closed)

Created:
4 years, 1 month ago by johnme
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix potential bug in push_test.js - do not cache subscription options - Prior to this patch, the application server key could be inadvertently cached, e.g. if a test in PushMessagingBrowserTest did the following: documentSubscribePush() removeManifest() documentSubscribePushWithoutKey() then the second push would actually use the cached key from the first. - No existing tests happen to hit the bug but that's just luck. BUG=660874 Review-Url: https://codereview.chromium.org/2460223004 Cr-Commit-Position: refs/heads/master@{#428983} (cherry picked from commit 5069448246d980f994a700bc937aba59dc6e9ab6) Rebased to adjust documentSubscribePushBadKey (which had been removed by https://codereview.chromium.org/2411733002 on master). Merge approval: https://crbug.com/659230#c25 Committed: https://chromium.googlesource.com/chromium/src/+/59705097c9ca9ee36d441860aaf06e00a70b8bff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -37 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/test/data/push_messaging/push_test.js View 5 chunks +19 lines, -12 lines 0 comments Download
D chrome/test/data/push_messaging/test_no_subscription_options.html View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
4 years, 1 month ago (2016-11-21 14:43:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59705097c9ca9ee36d441860aaf06e00a70b8bff.

Powered by Google App Engine
This is Rietveld 408576698