Chromium Code Reviews
DescriptionFix potential bug in push_test.js - do not cache subscription options
- Prior to this patch, the application server key could be inadvertently
cached, e.g. if a test in PushMessagingBrowserTest did the following:
documentSubscribePush()
removeManifest()
documentSubscribePushWithoutKey()
then the second push would actually use the cached key from the first.
- No existing tests happen to hit the bug but that's just luck.
BUG=660874
Review-Url: https://codereview.chromium.org/2460223004
Cr-Commit-Position: refs/heads/master@{#428983}
(cherry picked from commit 5069448246d980f994a700bc937aba59dc6e9ab6)
Rebased to adjust documentSubscribePushBadKey (which had been removed by
https://codereview.chromium.org/2411733002 on master).
Merge approval: https://crbug.com/659230#c25
Committed: https://chromium.googlesource.com/chromium/src/+/59705097c9ca9ee36d441860aaf06e00a70b8bff
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||