Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5671)

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 2517003003: Fix potential bug in push_test.js - do not cache subscription options (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/push_messaging/push_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
index c7ee2155c33fedb96698bc0c97ee59a4d21bd150..629c9b754ee5d1fb7156492218261f340a1c2a53 100644
--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
@@ -289,13 +289,6 @@ class PushMessagingBrowserTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(PushMessagingBrowserTest);
};
-class PushMessagingBrowserTestEmptySubscriptionOptions
- : public PushMessagingBrowserTest {
- std::string GetTestURL() override {
- return "/push_messaging/test_no_subscription_options.html";
- }
-};
-
void PushMessagingBrowserTest::RequestAndAcceptPermission() {
std::string script_result;
GetPermissionRequestManager()->set_auto_response_for_test(
@@ -512,7 +505,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, SubscribeFailureNoSenderId) {
script_result);
}
-IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTestEmptySubscriptionOptions,
+IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
RegisterFailureEmptyPushSubscriptionOptions) {
std::string script_result;
@@ -521,7 +514,8 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTestEmptySubscriptionOptions,
ASSERT_NO_FATAL_FAILURE(RequestAndAcceptPermission());
- ASSERT_TRUE(RunScript("documentSubscribePush()", &script_result));
+ ASSERT_TRUE(
+ RunScript("documentSubscribePushWithEmptyOptions()", &script_result));
EXPECT_EQ("NotAllowedError - Registration failed - permission denied",
script_result);
}
« no previous file with comments | « no previous file | chrome/test/data/push_messaging/push_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698