[Downloads] Consolidate Java DownloadItem/Info creation

[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.  Request headers
  are created using the traditionally wrong "referer".

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
Committed: https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6
Cr-Commit-Position: refs/heads/master@{#433650}

[gone, 2016-11-19 00:55:03]

Description was changed from

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
==========

to

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
==========

[gone, 2016-11-19 00:55:48]

Description was changed from

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
==========

to

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.  Request headers
  are created using the traditionally wrong "referer".

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
==========

[gone, 2016-11-19 00:57:32]

dfalcantara@chromium.org changed reviewers:
+ qinmin@chromium.org

[qinmin, 2016-11-21 17:45:14]

lgtm

[gone, 2016-11-21 19:52:17]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[gone, 2016-11-21 19:52:53]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 19:53:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-11-21 20:51:31]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-11-21 20:51:31]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-11-21 20:51:32]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2516823002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-11-21 20:51:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 21:07:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479761491788600,
"parent_rev": "18dbdc5cd0a7d0ebf995116a317565a214c9a3c1", "commit_rev":
"a9a768ab07383ca06b3ff7e3f551cae3fb56e050"}

[commit-bot: I haz the power, 2016-11-21 21:08:25]

Description was changed from

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.  Request headers
  are created using the traditionally wrong "referer".

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
==========

to

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.  Request headers
  are created using the traditionally wrong "referer".

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
==========

[commit-bot: I haz the power, 2016-11-21 21:08:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 21:13:32]

Description was changed from

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.  Request headers
  are created using the traditionally wrong "referer".

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630
==========

to

==========
[Downloads] Consolidate Java DownloadItem/Info creation

Consolidates how DownloadInfos are created across
DownloadManagerService and DownloadController.

Differences:
* DownloadItems created for DownloadController previously used
  DownloadItem::GetURL().  They've been changed to use
  DownloadItem::GetTabURL() instead to match DownloadManagerService.

* Similiarly, DownloadController used to use the
  DownloadItem::GetTargetFilePath().BaseName().  This has been
  switched to DownloadItem::GetFileNameToReportUser().

* "Referrer" is more common than "referer" in the codebase,
  despite the historical spec misspelling.  Switch the
  DownloadInfo class to use that instead.  Request headers
  are created using the traditionally wrong "referer".

Removed:
* There was an unused method in DownloadManagerService.  Nuked it.

BUG=654630

Committed: https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6
Cr-Commit-Position: refs/heads/master@{#433650}
==========

[commit-bot: I haz the power, 2016-11-21 21:13:35]

Patchset 2 (id:??) landed as
https://crrev.com/d4c7abab4259e2aba07659b3f71b288ff61ccec6
Cr-Commit-Position: refs/heads/master@{#433650}