Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4165)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2516823002: [Downloads] Consolidate Java DownloadItem/Info creation (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index 09ecf6d1871d61f2fde5859872f425d0d5254174..69d26207ce23fa69018efd565bff670a27eb5702 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -606,7 +606,7 @@ public class DownloadManagerService extends BroadcastReceiver implements
long downloadId = mDownloadManagerDelegate.addCompletedDownload(
downloadInfo.getFileName(), description, downloadInfo.getMimeType(),
downloadInfo.getFilePath(), downloadInfo.getContentLength(),
- downloadInfo.getOriginalUrl(), downloadInfo.getReferer(),
+ downloadInfo.getOriginalUrl(), downloadInfo.getReferrer(),
downloadInfo.getDownloadGuid());
downloadItem.setSystemDownloadId(downloadId);
return true;
@@ -886,7 +886,7 @@ public class DownloadManagerService extends BroadcastReceiver implements
request.setDescription(description);
request.setTitle(info.getFileName());
request.addRequestHeader("Cookie", info.getCookie());
- request.addRequestHeader("Referer", info.getReferer());
+ request.addRequestHeader("Referer", info.getReferrer());
request.addRequestHeader("User-Agent", info.getUserAgent());
DownloadManager manager =
@@ -1664,33 +1664,6 @@ public class DownloadManagerService extends BroadcastReceiver implements
@Override
public void purgeActiveNetworkList(long[] activeNetIds) {}
- @CalledByNative
- private static DownloadItem createDownloadItem(String guid, String displayName,
- String filepath, String url, String mimeType, long startTimestamp, long totalBytes,
- boolean hasBeenExternallyRemoved, boolean isIncognito, int state,
- int percentCompleted, boolean isPaused) {
- // Remap the MIME type first.
- File file = new File(filepath);
- String newMimeType =
- ChromeDownloadDelegate.remapGenericMimeType(mimeType, url, file.getName());
-
- DownloadInfo.Builder builder = new DownloadInfo.Builder()
- .setDownloadGuid(guid)
- .setFileName(displayName)
- .setFilePath(filepath)
- .setUrl(url)
- .setMimeType(newMimeType)
- .setContentLength(totalBytes)
- .setIsOffTheRecord(isIncognito)
- .setPercentCompleted(percentCompleted)
- .setIsPaused(isPaused)
- .setState(state);
- DownloadItem downloadItem = new DownloadItem(false, builder.build());
- downloadItem.setStartTime(startTimestamp);
- downloadItem.setHasBeenExternallyRemoved(hasBeenExternallyRemoved);
- return downloadItem;
- }
-
private static native boolean nativeIsSupportedMimeType(String mimeType);
private native long nativeInit();
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698