Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2516783002: Fix TSAN errors with reload_cache_control_browsertest.cc. (Closed)

Created:
4 years, 1 month ago by Alexei Svitkine (slow)
Modified:
4 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TSAN errors with reload_cache_control_browsertest.cc. Initializing the feature list in the ctor makes sure its initialized before threads get started that query its value. BUG=663850 Committed: https://crrev.com/f1c4940a6107ab9e26fcc63b57077d6fb0d918cf Cr-Commit-Position: refs/heads/master@{#433347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M content/browser/loader/reload_cache_control_browsertest.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Alexei Svitkine (slow)
4 years, 1 month ago (2016-11-18 23:26:39 UTC) #6
mmenke
On 2016/11/18 23:26:39, Alexei Svitkine (very slow) wrote: LGTM
4 years, 1 month ago (2016-11-19 00:00:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516783002/1
4 years, 1 month ago (2016-11-19 00:16:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 00:25:47 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 00:29:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1c4940a6107ab9e26fcc63b57077d6fb0d918cf
Cr-Commit-Position: refs/heads/master@{#433347}

Powered by Google App Engine
This is Rietveld 408576698