Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: content/browser/loader/reload_cache_control_browsertest.cc

Issue 2516783002: Fix TSAN errors with reload_cache_control_browsertest.cc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/reload_cache_control_browsertest.cc
diff --git a/content/browser/loader/reload_cache_control_browsertest.cc b/content/browser/loader/reload_cache_control_browsertest.cc
index 8999d37b1997a123f61b2b0a9ce72ad5832243b3..98352d50194b0eb517848ae37fafed62e3577cd3 100644
--- a/content/browser/loader/reload_cache_control_browsertest.cc
+++ b/content/browser/loader/reload_cache_control_browsertest.cc
@@ -39,15 +39,15 @@ struct RequestLog {
class ReloadCacheControlBrowserTest : public ContentBrowserTest {
protected:
- ReloadCacheControlBrowserTest() = default;
- ~ReloadCacheControlBrowserTest() override = default;
-
- void SetUpOnMainThread() override {
+ ReloadCacheControlBrowserTest() {
// TODO(toyoshim): Tests in this file depend on current reload behavior,
// and should be modified when we enable the new reload behavior.
scoped_feature_list_.InitAndDisableFeature(
features::kNonValidatingReloadOnNormalReload);
+ }
+ ~ReloadCacheControlBrowserTest() override = default;
+ void SetUpOnMainThread() override {
SetUpTestServerOnMainThread();
}
@@ -85,13 +85,13 @@ class ReloadCacheControlBrowserTest : public ContentBrowserTest {
class ReloadCacheControlWithAnExperimentBrowserTest
: public ReloadCacheControlBrowserTest {
protected:
- ReloadCacheControlWithAnExperimentBrowserTest() = default;
- ~ReloadCacheControlWithAnExperimentBrowserTest() override = default;
-
- void SetUpOnMainThread() override {
+ ReloadCacheControlWithAnExperimentBrowserTest() {
scoped_feature_list_.InitAndEnableFeature(
features::kNonValidatingReloadOnNormalReload);
+ }
+ ~ReloadCacheControlWithAnExperimentBrowserTest() override = default;
+ void SetUpOnMainThread() override {
SetUpTestServerOnMainThread();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698