Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: storage/browser/blob/blob_reader.cc

Issue 2516713002: [BlobStorage] Implementing disk. (Closed)
Patch Set: file flushing, stack track on reader error Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/blob_reader.cc
diff --git a/storage/browser/blob/blob_reader.cc b/storage/browser/blob/blob_reader.cc
index 1ec3002a8d103b34cc77ddc1f3f1ee150de82bf6..144a010e2ef9a63599c06c6aecd187a281ee158e 100644
--- a/storage/browser/blob/blob_reader.cc
+++ b/storage/browser/blob/blob_reader.cc
@@ -14,6 +14,7 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
+#include "base/debug/stack_trace.h"
#include "base/sequenced_task_runner.h"
#include "base/time/time.h"
#include "base/trace_event/trace_event.h"
@@ -245,6 +246,8 @@ bool BlobReader::IsInMemory() const {
void BlobReader::InvalidateCallbacksAndDone(int net_error,
net::CompletionCallback done) {
+ LOG(ERROR) << "Async error: " << net_error
michaeln 2016/12/02 20:41:07 is this needed in release builds or would DLOG or
dmurph 2016/12/02 21:53:07 Removed, this was for figuring out the browsertest
+ << " with stack: " << base::debug::StackTrace().ToString();
net_error_ = net_error;
weak_factory_.InvalidateWeakPtrs();
size_callback_.Reset();
@@ -254,6 +257,8 @@ void BlobReader::InvalidateCallbacksAndDone(int net_error,
}
BlobReader::Status BlobReader::ReportError(int net_error) {
+ LOG(ERROR) << "Error: " << net_error
+ << " with stack: " << base::debug::StackTrace().ToString();
net_error_ = net_error;
return Status::NET_ERROR;
}

Powered by Google App Engine
This is Rietveld 408576698