[BlobStorage] Implementing disk.

storage/browser/blob/blob_reader.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/blob/blob_reader.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <limits>
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
+#include "base/debug/stack_trace.h"
 #include "base/sequenced_task_runner.h"
 #include "base/time/time.h"
 #include "base/trace_event/trace_event.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/disk_cache/disk_cache.h"
 #include "storage/browser/blob/blob_data_handle.h"
 #include "storage/browser/blob/blob_data_snapshot.h"
 #include "storage/browser/fileapi/file_stream_reader.h"
 #include "storage/browser/fileapi/file_system_context.h"
@@ skipping 211 matching lines @@
   for (const auto& item : blob_data_->items()) {
     if (item->type() != DataElement::TYPE_BYTES) {
       return false;
     }
   }
   return true;
 }
 
 void BlobReader::InvalidateCallbacksAndDone(int net_error,
                                             net::CompletionCallback done) {
+  LOG(ERROR) << "Async error: " << net_error

[michaeln, 2016/12/02 20:41:07]

is this needed in release builds or would DLOG or VLOG be more appropiate?

[dmurph, 2016/12/02 21:53:07]

Removed, this was for figuring out the browsertests error.

+             << " with stack: " << base::debug::StackTrace().ToString();
   net_error_ = net_error;
   weak_factory_.InvalidateWeakPtrs();
   size_callback_.Reset();
   read_callback_.Reset();
   read_buf_ = nullptr;
   done.Run(net_error);
 }
 
 BlobReader::Status BlobReader::ReportError(int net_error) {
+  LOG(ERROR) << "Error: " << net_error
+             << " with stack: " << base::debug::StackTrace().ToString();
   net_error_ = net_error;
   return Status::NET_ERROR;
 }
 
 void BlobReader::AsyncCalculateSize(const net::CompletionCallback& done,
                                     BlobStatus status) {
   if (BlobStatusIsError(status)) {
     InvalidateCallbacksAndDone(ConvertBlobErrorToNetError(status), done);
     return;
   }
@@ skipping 397 matching lines @@
 void BlobReader::SetFileReaderAtIndex(
     size_t index,
     std::unique_ptr<FileStreamReader> reader) {
   if (reader)
     index_to_reader_[index] = std::move(reader);
   else
     index_to_reader_.erase(index);
 }
 
 }  // namespace storage