Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2516553002: Never resolve promises inside ScriptForbiddenScopes. (Closed)

Created:
4 years, 1 month ago by esprehn
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Never resolve promises inside ScriptForbiddenScopes. BUG=663476 Committed: https://crrev.com/863f2af2768cddc229e8822c622fa7dd539de290 Cr-Commit-Position: refs/heads/master@{#433149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
esprehn
4 years, 1 month ago (2016-11-18 05:48:22 UTC) #7
haraken
ok, LGTM
4 years, 1 month ago (2016-11-18 05:49:43 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-18 08:11:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516553002/1
4 years, 1 month ago (2016-11-18 08:13:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 08:21:37 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 08:23:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/863f2af2768cddc229e8822c622fa7dd539de290
Cr-Commit-Position: refs/heads/master@{#433149}

Powered by Google App Engine
This is Rietveld 408576698