Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2516503002:
MD Settings: add extension-controlled indicator to homepage (Closed)
|
Created:
4 years, 1 month ago by Dan Beam Modified:
4 years, 1 month ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: add extension-controlled indicator to homepage
R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/bdd3118a4e135f542c9b43af8b39b3a9957b00ce
Cr-Commit-Position: refs/heads/master@{#433066}
Patch Set 1 #Patch Set 2 : different slot #
Total comments: 3
Patch Set 3 : 80 col wrap #
Depends on Patchset: Messages
Total messages: 22 (15 generated)
Description was changed from ========== MD Settings: add extension-controlled indicator to homepage R=dpapad@chromium.org BUG=614265 ========== to ========== MD Settings: add extension-controlled indicator to homepage R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2516503002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/appearance_page/appearance_page.html (right): https://codereview.chromium.org/2516503002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/appearance_page/appearance_page.html:120: extension-can-be-disabled="[[prefs.homepage.extensionCanBeDisabled]]" both of these are long names... suggestions on how to wrap?
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2516503002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/appearance_page/appearance_page.html (right): https://codereview.chromium.org/2516503002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/appearance_page/appearance_page.html:120: extension-can-be-disabled="[[prefs.homepage.extensionCanBeDisabled]]" On 2016/11/17 at 23:28:23, Dan Beam wrote: > both of these are long names... suggestions on how to wrap? How about the following? extension-can-be-disabled="[[ prefs.homepage.extensionCanBeDisabled]]"
LGTM
https://codereview.chromium.org/2516503002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/appearance_page/appearance_page.html (right): https://codereview.chromium.org/2516503002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/appearance_page/appearance_page.html:120: extension-can-be-disabled="[[prefs.homepage.extensionCanBeDisabled]]" On 2016/11/17 23:36:05, dpapad wrote: > On 2016/11/17 at 23:28:23, Dan Beam wrote: > > both of these are long names... suggestions on how to wrap? > > How about the following? > > extension-can-be-disabled="[[ > prefs.homepage.extensionCanBeDisabled]]" Done.
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2516503002/#ps40001 (title: "80 col wrap")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: add extension-controlled indicator to homepage R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: add extension-controlled indicator to homepage R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bdd3118a4e135f542c9b43af8b39b3a9957b00ce Cr-Commit-Position: refs/heads/master@{#433066} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bdd3118a4e135f542c9b43af8b39b3a9957b00ce Cr-Commit-Position: refs/heads/master@{#433066} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
