Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2506323002: MD Settings: show an extension-controlled-indicator for proxy (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: show an extension-controlled-indicator for proxy R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c65535c6b7820178ed08e3bedd90ddbbc41f23a6 Cr-Commit-Position: refs/heads/master@{#433031}

Patch Set 1 #

Total comments: 3

Patch Set 2 : dpapad@ review #

Patch Set 3 : -@private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -9 lines) Patch
M chrome/browser/resources/settings/prefs/prefs.js View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.html View 3 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.js View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
Dan Beam
4 years, 1 month ago (2016-11-17 04:16:31 UTC) #2
dpapad
https://codereview.chromium.org/2506323002/diff/1/chrome/browser/resources/settings/system_page/system_page.js File chrome/browser/resources/settings/system_page/system_page.js (right): https://codereview.chromium.org/2506323002/diff/1/chrome/browser/resources/settings/system_page/system_page.js#newcode42 chrome/browser/resources/settings/system_page/system_page.js:42: document.querySelector('settings-ui').getPrefsElement().refresh('proxy'); With this selector system_page assumes that a settings-ui ...
4 years, 1 month ago (2016-11-17 18:36:34 UTC) #7
Dan Beam
https://codereview.chromium.org/2506323002/diff/1/chrome/browser/resources/settings/system_page/system_page.js File chrome/browser/resources/settings/system_page/system_page.js (right): https://codereview.chromium.org/2506323002/diff/1/chrome/browser/resources/settings/system_page/system_page.js#newcode42 chrome/browser/resources/settings/system_page/system_page.js:42: document.querySelector('settings-ui').getPrefsElement().refresh('proxy'); On 2016/11/17 18:36:34, dpapad wrote: > With this ...
4 years, 1 month ago (2016-11-17 19:12:25 UTC) #8
Dan Beam
https://codereview.chromium.org/2506323002/diff/1/chrome/browser/resources/settings/system_page/system_page.js File chrome/browser/resources/settings/system_page/system_page.js (right): https://codereview.chromium.org/2506323002/diff/1/chrome/browser/resources/settings/system_page/system_page.js#newcode42 chrome/browser/resources/settings/system_page/system_page.js:42: document.querySelector('settings-ui').getPrefsElement().refresh('proxy'); On 2016/11/17 19:12:25, Dan Beam wrote: > On ...
4 years, 1 month ago (2016-11-17 22:10:38 UTC) #10
dpapad
lgtm
4 years, 1 month ago (2016-11-17 22:14:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506323002/60001
4 years, 1 month ago (2016-11-17 23:18:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506323002/60001
4 years, 1 month ago (2016-11-18 00:34:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-18 01:23:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506323002/60001
4 years, 1 month ago (2016-11-18 02:32:24 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 1 month ago (2016-11-18 02:54:43 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 02:56:47 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c65535c6b7820178ed08e3bedd90ddbbc41f23a6
Cr-Commit-Position: refs/heads/master@{#433031}

Powered by Google App Engine
This is Rietveld 408576698