LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html - Issue 251643002: [CSS Grid Layout] Clamping the number of repetitions when using the repeat() function.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html

Issue 251643002: [CSS Grid Layout] Clamping the number of repetitions when using the repeat() function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
	Julien - ping for review 2014/04/25 15:50:34 Let's stick with an HTML5 doctype unless there are Let's stick with an HTML5 doctype unless there are some other requirements here.
	2 <html>

	3 <head>

	4 <script src="../../resources/check-layout.js"></script>

	5 <link href="resources/grid.css" rel="stylesheet">

	6 <style>

	7

	8 .maxRepetitionsTrackRepeat {

	9 grid-template-rows: repeat(10005, 1px);

	10 }

	11

	12 </style>

	13 </head>

	14 <body onload="checkLayout('.grid')">

	15

	16 <div>Test the values greater than the maximum repetitions value are clamped thro ugh CSS.</div>

	17

	18 <div>
	Julien - ping for review 2014/04/25 15:50:34 No need for this div. No need for this div.
	19 <div class="grid maxRepetitionsTrackRepeat" data-expected-height="10000"></div >
	Julien - ping for review 2014/04/25 15:50:34 We are doing boundary testing so it would be good We are doing boundary testing so it would be good to test a bit below the limit, the limit and above the limit. You're currently only testing the last one.
	20 </div>

	21

	22 </body>

	23 </html>

OLD	NEW