Inline StringValue into base::Value

base/json/json_parser.cc

Index: base/json/json_parser.cc
diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc
index cd427da9ea2537fa86c103452d72505731ab6129..f7b4179f2e320b88585ce2d69894f093b1c45411 100644
--- a/base/json/json_parser.cc
+++ b/base/json/json_parser.cc
@@ -151,6 +151,12 @@ class JSONStringValue : public Value {
     *out_value = UTF8ToUTF16(string_piece_);
     return true;
   }
+  // base::Value::GetAsString contains a proper implementation now, so the old
+  // behavior is copied here.
+  // TODO(jdoerrie): Clean this up when StringValue will be removed.

[vabr (Chromium), 2016/12/07 10:17:27]

nit: It is a good practice to also mention the bug number, e.g., as
TODO(crbug.com/646113), because it provides more context if needed. One can
still derive it from git blame, but having the number in the comment itself is
much easier to follow.

(Also elsewhere in the CL.)

[jdoerrie, 2016/12/08 09:59:34]

Done.

+  bool GetAsString(const StringValue** out_value) const override {
+    return false;
+  }
   Value* DeepCopy() const override { return new StringValue(string_piece_); }
   bool Equals(const Value* other) const override {
     std::string other_string;