Inline StringValue into base::Value

base/json/json_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_parser.h"
 
 #include <cmath>
 #include <utility>
 
 #include "base/logging.h"
@@ skipping 133 matching lines @@
 
   // Overridden from Value:
   bool GetAsString(std::string* out_value) const override {
     string_piece_.CopyToString(out_value);
     return true;
   }
   bool GetAsString(string16* out_value) const override {
     *out_value = UTF8ToUTF16(string_piece_);
     return true;
   }
+  // base::Value::GetAsString contains a proper implementation now, so the old
+  // behavior is copied here.
+  // TODO(jdoerrie): Clean this up when StringValue will be removed.

[vabr (Chromium), 2016/12/07 10:17:27]

nit: It is a good practice to also mention the bug number, e.g., as
TODO(crbug.com/646113), because it provides more context if needed. One can
still derive it from git blame, but having the number in the comment itself is
much easier to follow.

(Also elsewhere in the CL.)

[jdoerrie, 2016/12/08 09:59:34]

Done.

+  bool GetAsString(const StringValue** out_value) const override {
+    return false;
+  }
   Value* DeepCopy() const override { return new StringValue(string_piece_); }
   bool Equals(const Value* other) const override {
     std::string other_string;
     return other->IsType(TYPE_STRING) && other->GetAsString(&other_string) &&
         StringPiece(other_string) == string_piece_;
   }
 
  private:
   // The location in the original input stream.
   StringPiece string_piece_;
@@ skipping 825 matching lines @@
                                            const std::string& description) {
   if (line || column) {
     return StringPrintf("Line: %i, column: %i, %s",
         line, column, description.c_str());
   }
   return description;
 }
 
 }  // namespace internal
 }  // namespace base