Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2516313002: binding: Changes failing CHECKs to DCHECKs. (Closed)

Created:
4 years, 1 month ago by Yuki
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Changes failing CHECKs to DCHECKs. CHECKs added by http://crrev.com/2506563002 are failing on M56 and M57. This is very bad for users, so let's make them DCHECK for now. Will investigate why these checks are failing. BUG=666256 Committed: https://crrev.com/7c28f0f61d1899a90bfe15576d048eacea6b5891 Cr-Commit-Position: refs/heads/master@{#433509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Yuki
Could you review this CL?
4 years, 1 month ago (2016-11-21 06:25:31 UTC) #4
haraken
LGTM as a short-term fix.
4 years, 1 month ago (2016-11-21 06:26:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516313002/1
4 years, 1 month ago (2016-11-21 06:34:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276656) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-21 08:25:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516313002/1
4 years, 1 month ago (2016-11-21 08:56:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 11:14:39 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-21 11:16:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c28f0f61d1899a90bfe15576d048eacea6b5891
Cr-Commit-Position: refs/heads/master@{#433509}

Powered by Google App Engine
This is Rietveld 408576698