Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2516313002: binding: Changes failing CHECKs to DCHECKs. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
index e6772a687c2904405667b67b742c932b5f7e9319..82db35ef03c2c8806b5f2b29d6e9fbcfb4d90c9d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
@@ -120,10 +120,12 @@ void WindowProxy::disposeContext(GlobalDetachmentBehavior behavior) {
if (behavior == DetachGlobal) {
// Clean up state on the global proxy, which will be reused.
if (!m_globalProxy.isEmpty()) {
- CHECK(m_globalProxy == context->Global());
- CHECK_EQ(toScriptWrappable(context->Global()),
- toScriptWrappable(
- context->Global()->GetPrototype().As<v8::Object>()));
+ // TODO(yukishiino): This DCHECK failed on Canary (M57) and Dev (M56).
+ // We need to figure out why m_globalProxy != context->Global().
+ DCHECK(m_globalProxy == context->Global());
+ DCHECK_EQ(toScriptWrappable(context->Global()),
+ toScriptWrappable(
+ context->Global()->GetPrototype().As<v8::Object>()));
m_globalProxy.get().SetWrapperClassId(0);
}
V8DOMWrapper::clearNativeInfo(m_isolate, context->Global());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698