Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2516283002: Revert of Add TODO to BrowsingHistoryHandler regarding WebHistory deletion. (Closed)

Created:
4 years ago by Matt Giuca
Modified:
4 years ago
Reviewers:
msramek, calamity
CC:
chromium-reviews, Patrick Dubroy, dbeam+watch-history_chromium.org, pam+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add TODO to BrowsingHistoryHandler regarding WebHistory deletion. (patchset #2 id:20001 of https://codereview.chromium.org/2510823005/ ) Reason for revert: Compile failed (adds a new method definition without a declaration). BUG=667190 Original issue's description: > Add TODO to BrowsingHistoryHandler regarding WebHistory deletion. > > This CL is a followup to https://codereview.chromium.org/2455503004/. > > BUG=None > NOTRY=true > > Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7 > Cr-Commit-Position: refs/heads/master@{#433480} TBR=msramek@chromium.org,calamity@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/3f3c8b5afb2cf8e682e49fb3bf52004340f5e877 Cr-Commit-Position: refs/heads/master@{#433481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/ui/webui/browsing_history_handler.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Matt Giuca
Created Revert of Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.
4 years ago (2016-11-21 06:12:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2516283002/1
4 years ago (2016-11-21 06:12:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 06:14:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3f3c8b5afb2cf8e682e49fb3bf52004340f5e877 Cr-Commit-Position: refs/heads/master@{#433481}
4 years ago (2016-11-21 06:17:00 UTC) #8
msramek
4 years ago (2016-11-21 09:50:11 UTC) #9
Message was sent while issue was closed.
The diff in this CL is not an exact opposite of the diff of the reverted CL.

calamity@, it seems that by adding a comment to OnWebHistoryDeleted(), you
accidentally re-added the method which was at the very same time moved to
BrowsingHistoryService in https://codereview.chromium.org/2450453002

Would you mind adding the comment there instead? :)

Powered by Google App Engine
This is Rietveld 408576698