Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 2516283002: Revert of Add TODO to BrowsingHistoryHandler regarding WebHistory deletion. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/browsing_history_handler.h" 5 #include "chrome/browser/ui/webui/browsing_history_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
533 } 533 }
534 534
535 void BrowsingHistoryHandler::OnRemoveVisitsFailed() { 535 void BrowsingHistoryHandler::OnRemoveVisitsFailed() {
536 web_ui()->CallJavascriptFunctionUnsafe("deleteFailed"); 536 web_ui()->CallJavascriptFunctionUnsafe("deleteFailed");
537 } 537 }
538 538
539 void BrowsingHistoryHandler::HistoryDeleted() { 539 void BrowsingHistoryHandler::HistoryDeleted() {
540 web_ui()->CallJavascriptFunctionUnsafe("historyDeleted"); 540 web_ui()->CallJavascriptFunctionUnsafe("historyDeleted");
541 } 541 }
542 542
543 void BrowsingHistoryHandler::OnWebHistoryDeleted() {
544 // TODO(calamity): Only ignore web history deletions when they are actually
545 // initiated by us, rather than ignoring them whenever we are deleting.
546 if (!has_pending_delete_request_)
547 web_ui()->CallJavascriptFunctionUnsafe("historyDeleted");
548 }
549
550 void BrowsingHistoryHandler::HasOtherFormsOfBrowsingHistory( 543 void BrowsingHistoryHandler::HasOtherFormsOfBrowsingHistory(
551 bool has_other_forms, 544 bool has_other_forms,
552 bool has_synced_results) { 545 bool has_synced_results) {
553 web_ui()->CallJavascriptFunctionUnsafe( 546 web_ui()->CallJavascriptFunctionUnsafe(
554 "showNotification", base::FundamentalValue(has_synced_results), 547 "showNotification", base::FundamentalValue(has_synced_results),
555 base::FundamentalValue(has_other_forms)); 548 base::FundamentalValue(has_other_forms));
556 } 549 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698