third_party/WebKit/Source/wtf/text/WTFString.h - Issue 2516123002: Out-of-line WTF::String's destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 2516123002: Out-of-line WTF::String's destructor. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/WTFString.h

diff --git a/third_party/WebKit/Source/wtf/text/WTFString.h b/third_party/WebKit/Source/wtf/text/WTFString.h

index c2b55e4b312ec04c18ca580a3b9381824bf0a2ac..9e96791e46299bc5dc6237d4e4753147333298e9 100644

--- a/third_party/WebKit/Source/wtf/text/WTFString.h

+++ b/third_party/WebKit/Source/wtf/text/WTFString.h

@@ -99,6 +99,8 @@ class WTF_EXPORT String {

String(StringImpl* impl) : m_impl(impl) {}

String(PassRefPtr<StringImpl> impl) : m_impl(impl) {}

+ ~String();

Mikhail 2016/11/21 06:51:02 This will remove implicitly-declared move construc

dcheng 2016/11/22 01:30:08 Ah, good catch. I was wondering about the ASAN fai

void swap(String& o) { m_impl.swap(o.m_impl); }

template <typename CharType>

« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | no next file with comments »