Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 2516123002: Out-of-line WTF::String's destructor. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 String(const char* characters, unsigned length); 92 String(const char* characters, unsigned length);
93 93
94 // Construct a string with latin1 data, from a null-terminated source. 94 // Construct a string with latin1 data, from a null-terminated source.
95 String(const LChar* characters); 95 String(const LChar* characters);
96 String(const char* characters); 96 String(const char* characters);
97 97
98 // Construct a string referencing an existing StringImpl. 98 // Construct a string referencing an existing StringImpl.
99 String(StringImpl* impl) : m_impl(impl) {} 99 String(StringImpl* impl) : m_impl(impl) {}
100 String(PassRefPtr<StringImpl> impl) : m_impl(impl) {} 100 String(PassRefPtr<StringImpl> impl) : m_impl(impl) {}
101 101
102 ~String();
Mikhail 2016/11/21 06:51:02 This will remove implicitly-declared move construc
dcheng 2016/11/22 01:30:08 Ah, good catch. I was wondering about the ASAN fai
103
102 void swap(String& o) { m_impl.swap(o.m_impl); } 104 void swap(String& o) { m_impl.swap(o.m_impl); }
103 105
104 template <typename CharType> 106 template <typename CharType>
105 static String adopt(StringBuffer<CharType>& buffer) { 107 static String adopt(StringBuffer<CharType>& buffer) {
106 if (!buffer.length()) 108 if (!buffer.length())
107 return StringImpl::empty(); 109 return StringImpl::empty();
108 return String(buffer.release()); 110 return String(buffer.release());
109 } 111 }
110 112
111 bool isNull() const { return !m_impl; } 113 bool isNull() const { return !m_impl; }
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 using WTF::emptyString; 654 using WTF::emptyString;
653 using WTF::emptyString16Bit; 655 using WTF::emptyString16Bit;
654 using WTF::charactersAreAllASCII; 656 using WTF::charactersAreAllASCII;
655 using WTF::equal; 657 using WTF::equal;
656 using WTF::find; 658 using WTF::find;
657 using WTF::isAllSpecialCharacters; 659 using WTF::isAllSpecialCharacters;
658 using WTF::isSpaceOrNewline; 660 using WTF::isSpaceOrNewline;
659 661
660 #include "wtf/text/AtomicString.h" 662 #include "wtf/text/AtomicString.h"
661 #endif // WTFString_h 663 #endif // WTFString_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698