Landing Recent QUIC changes until Mon Nov 14 04:43:50 2016 +0000

Landing Recent QUIC changes until Mon Nov 14 04:43:50 2016 +0000

Sync flags.
https://codereview.chromium.org/2506173006/

Fix version manager that flip flag in-flight does not make supported versions change. Protected by ENABLED FLAGS_quic_fix_version_manager.
Merge internal change: 139033797
https://codereview.chromium.org/2512163004/

turn off QUIC v36 (only used by chrome canary)
This CL also introduces v3 of the version 36 flag, although
initially blocked.
Merge internal change: 138898517
https://codereview.chromium.org/2512273002/

Move QUIC error code utility methods to quic_error_codes.{h,cc}, and rename them slightly.  No behavior change.
Merge internal change: 138891075
https://codereview.chromium.org/2517513004/

Delete unused HexDecode method. No behavior change.
Merge internal change: 138881760
https://codereview.chromium.org/2515873002/

Add a --quic_allow_chlo_buffering flag. Default value is true, no behavior change.
Merge internal change: 138879292
https://codereview.chromium.org/2519573002/

Remove strike-register code from QuicCryptoServerConfig
Merge internal change: 138801414
https://codereview.chromium.org/2513113002/

Remove QuicUtils::AsChars by casting directly. No behavior change.
Merge internal change: 138794643
https://codereview.chromium.org/2512123004/

Delete out of date comment, and unused forward declaration. No behavior change.
Merge internal change: 138787794
https://codereview.chromium.org/2511263004/

Move test only MakeIOVector method to test_tools/quic_test_utils.h. No behavior change.
Merge internal change: 138774842
https://codereview.chromium.org/2517673002/

Deprecate FLAGS_quic_enable_version_35.
Merge internal change: 138774618
https://codereview.chromium.org/2515783003/

Moves QuicTag typedefs, and QuicTag utility methods to quic_tag.{h,cc}. No behavior change.
Merge internal change: 138768058
https://codereview.chromium.org/2517603003/

Move QuicIoVector into its own header file. No behavior change.
Also #includes build_config.h from net/base/iovec.h, to fix an implicit include
order dependency uncovered by this change.
Merge internal change: 138765876
https://codereview.chromium.org/2512063003/

deprecate FLAGS_quic_disable_pre_34
Removes support for QUIC v32 and v33 which means:
* Strike Registers are dead!
* Entropy is dead!
* ACKs never contain missing packets
* Diversification nonces are always present in SHLOs
Merge internal change: 138716334
https://codereview.chromium.org/2515613002/

Get rid of the unused Priority argument to QuicUtils::FindMutualTag. No behavior change.
Merge internal change: 138671587
https://codereview.chromium.org/2508393002/

Delete unused QuicNegotiableTag class. No behavior change.
Merge internal change: 138668855
https://codereview.chromium.org/2505223004/

In case of stateless reject, change quic connection close source from client to server on client side. Not flag protected.
Merge internal change: 138654307
https://codereview.chromium.org/2511893003/

Move kInvalidPacketNumber to QuicDispatcher: the only place it is used. No behavior change.
Merge internal change: 138637526
https://codereview.chromium.org/2517463002/

adds std:: to stl types
Merge internal change: 138572988
https://codereview.chromium.org/2512833002/

Remove unused #includes from quic_utils.cc
Merge internal change: 138558915
https://codereview.chromium.org/2505223003/

Move enums from QuicProtocol to QuicTypes. No behavior change.
Merge internal change: 138558656
https://codereview.chromium.org/2505993004/

Move some more constants and typedefs around. No behavior change.
Merge internal change: 138536933
https://codereview.chromium.org/2509053004/

Move QuicVersionNegotiationState into QuicConnection, the only place it is used. No behavior change.
Merge internal change: 138524861
https://codereview.chromium.org/2512793002/

Minor refactors to enable sending an Expect-CT header more easily.
Merge internal change: 138517020
https://codereview.chromium.org/2516433002/

Move QUIC error codes to quic_error_codes.h. No behavior change.
Merge internal change: 138514651
https://codereview.chromium.org/2514493002/

Make QUIC_BAD_MULTIPATH_FLAG error log entry more informative.
Merge internal change: 138507433
https://codereview.chromium.org/2506013006/

Refactoring output of ProofSource::GetProof (no functional changes).
Merge internal change: 138432459
https://codereview.chromium.org/2511643002/

Move QuicBufferAllocator into its own .cc/.h. No behavior change.
Merge internal change: 138427795
https://codereview.chromium.org/2509033004/

Removing unused shared_writer() method in quic_per_connection_packet_writer.h
Merge internal change: 138426989
https://codereview.chromium.org/2508933004/

Update QuicSpdyClientStream::OnStreamFrame comment as it is no longer accurate: we do support bidi streaming.
Merge internal change: 138426713
https://codereview.chromium.org/2509903002/

Deprecate FLAGS_quic_only_track_sent_packets.
Merge internal change: 138420227
https://codereview.chromium.org/2509153002/

Deprecates FLAGS_spdy_forbid_connection_response_header.
Merge internal change: 138412694
https://codereview.chromium.org/2504403003/

Move definitions and methods related to QUIC versions, into quic_versions.{h,cc}. No behavior change.
Merge internal change: 138412688
https://codereview.chromium.org/2507953002/

Deprecate FLAGS_quic_limit_cubic_cwnd_increase.
Merge internal change: 138410843
https://codereview.chromium.org/2510873002/

Move QUIC typedefs and constants into files other than quic_protocol.h. No behavior change.
Merge internal change: 138405840
https://codereview.chromium.org/2506903002/

Make a QuicDefaultPacketWriter method virtual, and check member variable directly. No behavior change.
Merge internal change: 138383388
https://codereview.chromium.org/2502593003/

R=rch@chromium.org
BUG=

Committed: https://crrev.com/94250b8cb6982017f24d55cd1b26140ed274e0b2
Cr-Commit-Position: refs/heads/master@{#433422}

[mpw, 2016-11-19 04:59:43]

The CQ bit was checked by mpw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 04:59:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 05:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 05:14:22]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Ryan Hamilton, 2016-11-19 05:41:47]

LGTM, but looks like an unused local function.

../../net/quic/chromium/quic_connection_logger.cc:260:6: error: 'void
net::{anonymous}::UpdatePacketGapSentHistogram(size_t)' defined but not used
[-Werror=unused-function]
 void UpdatePacketGapSentHistogram(size_t num_consecutive_missing_packets) {

[mpw, 2016-11-19 17:09:16]

The CQ bit was checked by mpw@chromium.org

[mpw, 2016-11-19 17:09:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2516033003/#ps20001
(title: "Remove unused UpdatePacketGapSentHistogram() function.")

[commit-bot: I haz the power, 2016-11-19 17:09:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 18:14:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-19 18:15:53]

Description was changed from

==========
Landing Recent QUIC changes until Mon Nov 14 04:43:50 2016 +0000

Sync flags.
https://codereview.chromium.org/2506173006/

Fix version manager that flip flag in-flight does not make supported versions
change. Protected by ENABLED FLAGS_quic_fix_version_manager.
Merge internal change: 139033797
https://codereview.chromium.org/2512163004/

turn off QUIC v36 (only used by chrome canary)
This CL also introduces v3 of the version 36 flag, although
initially blocked.
Merge internal change: 138898517
https://codereview.chromium.org/2512273002/

Move QUIC error code utility methods to quic_error_codes.{h,cc}, and rename them
slightly.  No behavior change.
Merge internal change: 138891075
https://codereview.chromium.org/2517513004/

Delete unused HexDecode method. No behavior change.
Merge internal change: 138881760
https://codereview.chromium.org/2515873002/

Add a --quic_allow_chlo_buffering flag. Default value is true, no behavior
change.
Merge internal change: 138879292
https://codereview.chromium.org/2519573002/

Remove strike-register code from QuicCryptoServerConfig
Merge internal change: 138801414
https://codereview.chromium.org/2513113002/

Remove QuicUtils::AsChars by casting directly. No behavior change.
Merge internal change: 138794643
https://codereview.chromium.org/2512123004/

Delete out of date comment, and unused forward declaration. No behavior change.
Merge internal change: 138787794
https://codereview.chromium.org/2511263004/

Move test only MakeIOVector method to test_tools/quic_test_utils.h. No behavior
change.
Merge internal change: 138774842
https://codereview.chromium.org/2517673002/

Deprecate FLAGS_quic_enable_version_35.
Merge internal change: 138774618
https://codereview.chromium.org/2515783003/

Moves QuicTag typedefs, and QuicTag utility methods to quic_tag.{h,cc}. No
behavior change.
Merge internal change: 138768058
https://codereview.chromium.org/2517603003/

Move QuicIoVector into its own header file. No behavior change.
Also #includes build_config.h from net/base/iovec.h, to fix an implicit include
order dependency uncovered by this change.
Merge internal change: 138765876
https://codereview.chromium.org/2512063003/

deprecate FLAGS_quic_disable_pre_34
Removes support for QUIC v32 and v33 which means:
* Strike Registers are dead!
* Entropy is dead!
* ACKs never contain missing packets
* Diversification nonces are always present in SHLOs
Merge internal change: 138716334
https://codereview.chromium.org/2515613002/

Get rid of the unused Priority argument to QuicUtils::FindMutualTag. No behavior
change.
Merge internal change: 138671587
https://codereview.chromium.org/2508393002/

Delete unused QuicNegotiableTag class. No behavior change.
Merge internal change: 138668855
https://codereview.chromium.org/2505223004/

In case of stateless reject, change quic connection close source from client to
server on client side. Not flag protected.
Merge internal change: 138654307
https://codereview.chromium.org/2511893003/

Move kInvalidPacketNumber to QuicDispatcher: the only place it is used. No
behavior change.
Merge internal change: 138637526
https://codereview.chromium.org/2517463002/

adds std:: to stl types
Merge internal change: 138572988
https://codereview.chromium.org/2512833002/

Remove unused #includes from quic_utils.cc
Merge internal change: 138558915
https://codereview.chromium.org/2505223003/

Move enums from QuicProtocol to QuicTypes. No behavior change.
Merge internal change: 138558656
https://codereview.chromium.org/2505993004/

Move some more constants and typedefs around. No behavior change.
Merge internal change: 138536933
https://codereview.chromium.org/2509053004/

Move QuicVersionNegotiationState into QuicConnection, the only place it is used.
No behavior change.
Merge internal change: 138524861
https://codereview.chromium.org/2512793002/

Minor refactors to enable sending an Expect-CT header more easily.
Merge internal change: 138517020
https://codereview.chromium.org/2516433002/

Move QUIC error codes to quic_error_codes.h. No behavior change.
Merge internal change: 138514651
https://codereview.chromium.org/2514493002/

Make QUIC_BAD_MULTIPATH_FLAG error log entry more informative.
Merge internal change: 138507433
https://codereview.chromium.org/2506013006/

Refactoring output of ProofSource::GetProof (no functional changes).
Merge internal change: 138432459
https://codereview.chromium.org/2511643002/

Move QuicBufferAllocator into its own .cc/.h. No behavior change.
Merge internal change: 138427795
https://codereview.chromium.org/2509033004/

Removing unused shared_writer() method in quic_per_connection_packet_writer.h
Merge internal change: 138426989
https://codereview.chromium.org/2508933004/

Update QuicSpdyClientStream::OnStreamFrame comment as it is no longer accurate:
we do support bidi streaming.
Merge internal change: 138426713
https://codereview.chromium.org/2509903002/

Deprecate FLAGS_quic_only_track_sent_packets.
Merge internal change: 138420227
https://codereview.chromium.org/2509153002/

Deprecates FLAGS_spdy_forbid_connection_response_header.
Merge internal change: 138412694
https://codereview.chromium.org/2504403003/

Move definitions and methods related to QUIC versions, into
quic_versions.{h,cc}. No behavior change.
Merge internal change: 138412688
https://codereview.chromium.org/2507953002/

Deprecate FLAGS_quic_limit_cubic_cwnd_increase.
Merge internal change: 138410843
https://codereview.chromium.org/2510873002/

Move QUIC typedefs and constants into files other than quic_protocol.h. No
behavior change.
Merge internal change: 138405840
https://codereview.chromium.org/2506903002/

Make a QuicDefaultPacketWriter method virtual, and check member variable
directly. No behavior change.
Merge internal change: 138383388
https://codereview.chromium.org/2502593003/

R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Mon Nov 14 04:43:50 2016 +0000

Sync flags.
https://codereview.chromium.org/2506173006/

Fix version manager that flip flag in-flight does not make supported versions
change. Protected by ENABLED FLAGS_quic_fix_version_manager.
Merge internal change: 139033797
https://codereview.chromium.org/2512163004/

turn off QUIC v36 (only used by chrome canary)
This CL also introduces v3 of the version 36 flag, although
initially blocked.
Merge internal change: 138898517
https://codereview.chromium.org/2512273002/

Move QUIC error code utility methods to quic_error_codes.{h,cc}, and rename them
slightly.  No behavior change.
Merge internal change: 138891075
https://codereview.chromium.org/2517513004/

Delete unused HexDecode method. No behavior change.
Merge internal change: 138881760
https://codereview.chromium.org/2515873002/

Add a --quic_allow_chlo_buffering flag. Default value is true, no behavior
change.
Merge internal change: 138879292
https://codereview.chromium.org/2519573002/

Remove strike-register code from QuicCryptoServerConfig
Merge internal change: 138801414
https://codereview.chromium.org/2513113002/

Remove QuicUtils::AsChars by casting directly. No behavior change.
Merge internal change: 138794643
https://codereview.chromium.org/2512123004/

Delete out of date comment, and unused forward declaration. No behavior change.
Merge internal change: 138787794
https://codereview.chromium.org/2511263004/

Move test only MakeIOVector method to test_tools/quic_test_utils.h. No behavior
change.
Merge internal change: 138774842
https://codereview.chromium.org/2517673002/

Deprecate FLAGS_quic_enable_version_35.
Merge internal change: 138774618
https://codereview.chromium.org/2515783003/

Moves QuicTag typedefs, and QuicTag utility methods to quic_tag.{h,cc}. No
behavior change.
Merge internal change: 138768058
https://codereview.chromium.org/2517603003/

Move QuicIoVector into its own header file. No behavior change.
Also #includes build_config.h from net/base/iovec.h, to fix an implicit include
order dependency uncovered by this change.
Merge internal change: 138765876
https://codereview.chromium.org/2512063003/

deprecate FLAGS_quic_disable_pre_34
Removes support for QUIC v32 and v33 which means:
* Strike Registers are dead!
* Entropy is dead!
* ACKs never contain missing packets
* Diversification nonces are always present in SHLOs
Merge internal change: 138716334
https://codereview.chromium.org/2515613002/

Get rid of the unused Priority argument to QuicUtils::FindMutualTag. No behavior
change.
Merge internal change: 138671587
https://codereview.chromium.org/2508393002/

Delete unused QuicNegotiableTag class. No behavior change.
Merge internal change: 138668855
https://codereview.chromium.org/2505223004/

In case of stateless reject, change quic connection close source from client to
server on client side. Not flag protected.
Merge internal change: 138654307
https://codereview.chromium.org/2511893003/

Move kInvalidPacketNumber to QuicDispatcher: the only place it is used. No
behavior change.
Merge internal change: 138637526
https://codereview.chromium.org/2517463002/

adds std:: to stl types
Merge internal change: 138572988
https://codereview.chromium.org/2512833002/

Remove unused #includes from quic_utils.cc
Merge internal change: 138558915
https://codereview.chromium.org/2505223003/

Move enums from QuicProtocol to QuicTypes. No behavior change.
Merge internal change: 138558656
https://codereview.chromium.org/2505993004/

Move some more constants and typedefs around. No behavior change.
Merge internal change: 138536933
https://codereview.chromium.org/2509053004/

Move QuicVersionNegotiationState into QuicConnection, the only place it is used.
No behavior change.
Merge internal change: 138524861
https://codereview.chromium.org/2512793002/

Minor refactors to enable sending an Expect-CT header more easily.
Merge internal change: 138517020
https://codereview.chromium.org/2516433002/

Move QUIC error codes to quic_error_codes.h. No behavior change.
Merge internal change: 138514651
https://codereview.chromium.org/2514493002/

Make QUIC_BAD_MULTIPATH_FLAG error log entry more informative.
Merge internal change: 138507433
https://codereview.chromium.org/2506013006/

Refactoring output of ProofSource::GetProof (no functional changes).
Merge internal change: 138432459
https://codereview.chromium.org/2511643002/

Move QuicBufferAllocator into its own .cc/.h. No behavior change.
Merge internal change: 138427795
https://codereview.chromium.org/2509033004/

Removing unused shared_writer() method in quic_per_connection_packet_writer.h
Merge internal change: 138426989
https://codereview.chromium.org/2508933004/

Update QuicSpdyClientStream::OnStreamFrame comment as it is no longer accurate:
we do support bidi streaming.
Merge internal change: 138426713
https://codereview.chromium.org/2509903002/

Deprecate FLAGS_quic_only_track_sent_packets.
Merge internal change: 138420227
https://codereview.chromium.org/2509153002/

Deprecates FLAGS_spdy_forbid_connection_response_header.
Merge internal change: 138412694
https://codereview.chromium.org/2504403003/

Move definitions and methods related to QUIC versions, into
quic_versions.{h,cc}. No behavior change.
Merge internal change: 138412688
https://codereview.chromium.org/2507953002/

Deprecate FLAGS_quic_limit_cubic_cwnd_increase.
Merge internal change: 138410843
https://codereview.chromium.org/2510873002/

Move QUIC typedefs and constants into files other than quic_protocol.h. No
behavior change.
Merge internal change: 138405840
https://codereview.chromium.org/2506903002/

Make a QuicDefaultPacketWriter method virtual, and check member variable
directly. No behavior change.
Merge internal change: 138383388
https://codereview.chromium.org/2502593003/

R=rch@chromium.org
BUG=

Committed: https://crrev.com/94250b8cb6982017f24d55cd1b26140ed274e0b2
Cr-Commit-Position: refs/heads/master@{#433422}
==========

[commit-bot: I haz the power, 2016-11-19 18:15:55]

Patchset 2 (id:??) landed as
https://crrev.com/94250b8cb6982017f24d55cd1b26140ed274e0b2
Cr-Commit-Position: refs/heads/master@{#433422}

[mpw, 2016-11-19 18:22:23]

On 2016/11/19 18:15:55, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/94250b8cb6982017f24d55cd1b26140ed274e0b2
> Cr-Commit-Position: refs/heads/master@{#433422}

Thanks for all the reviews!